Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workaround legal swipe actions from the left side #8

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

ReDetection
Copy link
Contributor

How I was able to fix #6

@ReDetection
Copy link
Contributor Author

ReDetection commented Jan 13, 2021

I just noticed that proposed solution might be not optimal. What I did was to require all other gesture recognizers to fail (basically force-included all gestures to fall into the trap and opt out scroll-view one). Maybe we should instead only require UITableView recognizers to fail in order for EZ pan recognizer to recognize (so the other way around – none are required to fail except what we want to work). I have two reasons in mind:

  1. In my app I suddenly start to conflict with UXCam pod (basically a visor) – they seem to install global pinch gesture recognizer which also doesn't fail quickly.
  2. Future iOS updates might add more gesture recognizers and I find "opt-in" way safer

I will include my updated solution here and push a new commit, but sure it's up to you which way to choose.

@Enricoza
Copy link
Owner

I'm not sure this is the proper way forward.
Need to further investigate, but probably we're gonna need to defer some of this responsibility to the app which actually knows what kind of gesture it uses rather than we having to guess for it.

@ReDetection
Copy link
Contributor Author

Sounds reasonable. Maybe a closure in the EZNavigationConfiguration? Please let me know if you have a suggestion or feel free to close the PR if your own way :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pan-To-Pop conflicts with leadingSwipeActions on UITableView cells
2 participants