-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pan-To-Pop conflicts with leadingSwipeActions
on UITableView cells
#6
Comments
I think it's worth to look into |
OK I'm stuck again. There are two system recognizers we would be probably interested in:
You can see for the shitty workaround in my demo-delegate branch. |
The best debug trick I know is to set a symbolic breakpoint on |
Ha, scroll view exposes it's pan gesture recognizer :) so the workaround just got a lot better. Please see the #8 |
Hi @ReDetection, I had found the Anyway thanks also for the PR, it's highly appreciated. Unfortunately I can't review it right now but I will look at it later today. |
I had this issue in my app as well and I managed to fix it by recursively searching for the tableView in the last viewController of the navigation stack. Once you find the tableView you can simply check for isEditing and then return. I attached the code below. ` private func handleGestureRecognizer(_ gestureRecognizer: UIPanGestureRecognizer, forPop: Bool) {
|
Hi @VasApps! First and foremost, thank you for your input. Unfortunately I think your issue is not the same we are talking about in this thread and your solution is, anyway, not really viable. Here we are talking about a tableView that has the method That said, assuming there is another issue when a tableView is in editing mode, your solution would prevent whatever pop gesture (if there is any tableView in editing mode) while still capturing the gesture priority and therefore preventing whatever other left-to-right pan gesture that goes in conflict. This is not the intended behavior. Even if it were, I don't think that looking for the tableView recursively would be something that can be part of this library. If you feel like I miss interpreted something you just said, you can correct me and let me understand better. |
On a tableView with
leadingSwipeActions
thepan-to-pop
gesture takes precedence over the_UISwipeActionPanGestureRecognizer
of the tableView, making it impossible to show and activate those leading actions.It should be allowed to, at least, disable the pan-to-pop entirely on some view controllers or, even better, it should be allowed to make it require the other gesture to fail and, therefore, take precedence.
The text was updated successfully, but these errors were encountered: