Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Button loading binding does not work #873

Open
evshi opened this issue Oct 18, 2024 · 0 comments · May be fixed by #874
Open

Button loading binding does not work #873

evshi opened this issue Oct 18, 2024 · 0 comments · May be fixed by #874
Assignees
Labels
bug Something isn't working p1 High priority

Comments

@evshi
Copy link
Contributor

evshi commented Oct 18, 2024

Describe the bug
Using an expression for the button loading prop does not update properly. This is because the prop is never registered as a binding it is overwritten with local state.

To Reproduce
Steps to reproduce the behavior:

  1. Create a button with a loading prop and bind to some expression
  2. Trigger expression to true
  3. Button loading state does not update

Expected behavior
Button loading state should update

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

  • OS: [e.g. iOS]
  • Browser [e.g. chrome, safari]
  • Version [e.g. 22]

Smartphone (please complete the following information):

  • Device: [e.g. iPhone6]
  • OS: [e.g. iOS8.1]
  • Browser [e.g. stock browser, safari]
  • Version [e.g. 22]

Additional context
Write tests!!!

@evshi evshi added bug Something isn't working p1 High priority labels Oct 18, 2024
@sagardspeed2 sagardspeed2 linked a pull request Oct 18, 2024 that will close this issue
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working p1 High priority
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants