Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing dictionary entries #187

Open
mwilensky768 opened this issue Feb 3, 2020 · 10 comments
Open

Missing dictionary entries #187

mwilensky768 opened this issue Feb 3, 2020 · 10 comments
Labels
documentation A request for more documentation

Comments

@mwilensky768
Copy link

mwilensky768 commented Feb 3, 2020

There are certain default settings in pipeline_scripts/FHD_IDL_wrappers/eor_wrapper_defaults.pro that do not have dictionary entries. I think that if FHD is doing something (or disabling something) by default, there should be dictionary entries with a helpful explanation if possible. Many of these keywords are in the dictionary, but they appear in such a form as

cleanup=0

which is also how it appears in eor_wrapper_defaults.pro. Perhaps someone meant to close the loop on this earlier and hasn't gotten around to it, although some of these unexplained keywords do not have the same default listed as in the wrapper. In any case, I don't know what the following (default) keywords do and they do not have entries [this is how they appear in eor_wrapper_defaults.pro]:

cleanup=0
combine_healpix=0
vis_baseline_hist=1
calibration_visibilities_subtract=0
combine_obs=0
no_restrict_cal_sources=1
calibration_flag_iterate=0
interpolate_kernel=1
calibration_catalog_file_path=filepath('GLEAM_v2_plus_rlb2019.sav',root=rootdir('FHD'),subdir='catalog_data')

I'm very confident that calibration_catalog_file_path just sets the source catalog that is used in the calibration model. The rest are not obvious to me.

@mwilensky768 mwilensky768 added the documentation A request for more documentation label Feb 3, 2020
@isullivan
Copy link
Contributor

isullivan commented Feb 3, 2020

A few quick descriptions of these

cleanup - deletes intermediate data products that can easily be reproduced, to save disk space.
combine_healpix - an older version for integrating all observations from one FHD run to a single Healpix-gridded image.
vis_baseline_hist - ? (not one of mine)
calibration_visibilities_subtract - should probably be deprecated. This subtracts the model visibilities from the calibrated dirty visibilities at the end of calibration, leaving only residual visibilities.
combine_obs - another option for integrating observations from a single FHD run. This one does not use Healpix, but just picks one of the observations' ortho-slant projection and warps the others to match.
no_restrict_cal_sources - ignores beam threshold values and and edge distance when selecting sources to include in the calibration catalog.
calibration_flag_iterate - number of times to repeat calibration in order to better identify and flag bad tiles, and exclude them from contributing to the result.
interpolate_kernel - use interpolation of the gridding kernel while gridding and degridding, rather than selecting the closest super-resolution kernel.

@mwilensky768
Copy link
Author

Thanks @isullivan I'll put these in the dictionary on the documentation branch.

@mwilensky768 mwilensky768 changed the title Default settings that do not have dictionary entries Missing dictionary entries Feb 11, 2020
@mwilensky768
Copy link
Author

mwilensky768 commented Feb 11, 2020

I have added what I could from @isullivan's descriptions. Things that are still missing include:

  • vis_baseline_hist

@rlbyrne and I also noticed that

  • debug_dim

is missing. It seems to interact with

  • psf_dim

and we do not know if that itself is a keyword.

@rlbyrne
Copy link
Contributor

rlbyrne commented Feb 11, 2020

Also:

  • model_delay_filter

@rlbyrne
Copy link
Contributor

rlbyrne commented May 1, 2020

More keywords that need to be added:

  • beam_residual_threshold
  • beam_dim_fit (this is both a keyword and a function, which isn't great)
  • sim_over_calibrate
  • beam_threshold

@rlbyrne
Copy link
Contributor

rlbyrne commented May 18, 2020

And another deconvolution keyword:

  • deconvolution_add_threshold (defaults to 0.8)

@rlbyrne
Copy link
Contributor

rlbyrne commented Aug 31, 2020

Also (see #225):

  • max_cal_iter

@bhazelton
Copy link
Member

bhazelton commented Oct 16, 2020

Also:

  • save_visibilities
  • model_uv_transfer

@rlbyrne
Copy link
Contributor

rlbyrne commented May 26, 2021

Another missing dictionary entry:

  • nside

@rlbyrne
Copy link
Contributor

rlbyrne commented Sep 23, 2021

More missing dictionary entries:

  • no_frequency_flagging (also should be changed to avoid double negative)
  • precess
  • beam_diff_image
  • output_residual_histogram
  • show_beam_contour

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation A request for more documentation
Projects
None yet
Development

No branches or pull requests

4 participants