Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fhd_struct_init_meta and fhd_struct_init_obs tile flag bug #311

Open
SkyWa7ch3r opened this issue Aug 25, 2023 · 0 comments
Open

fhd_struct_init_meta and fhd_struct_init_obs tile flag bug #311

SkyWa7ch3r opened this issue Aug 25, 2023 · 0 comments

Comments

@SkyWa7ch3r
Copy link
Contributor

SkyWa7ch3r commented Aug 25, 2023

While translating and testing for PyFHD I noticed the tile_flag variable inside fhd_struct_init_meta ends up with indexes beyond the array during it's creation furthermore, it ends up flagging tiles different for different polarizations. the end result is in fhd_struct_init_obs when applying the meta.tile_flag to tile_use on 2 polarizations we end up with flagged tiles, while on 4 polarizations we end up with no flagged tiles.

For now in PyFHD I apply the single_i to the flag column inside the metafits file and this gets read into the meta['tile_flag'] dictionary value which then gets applied to obs['baseline_info']['tile_use'] = 1 - meta['tile_flag'], is this a suitable approach that could be done in FHD as well?

This issue can be tested with the observation 1088716176, which is one of the observations used to test PyFHD via WODEN simulations or otherwise.

@SkyWa7ch3r SkyWa7ch3r changed the title fhd_struct_init_meta and fhd_strucct_init_obs tile flag bug fhd_struct_init_meta and fhd_struct_init_obs tile flag bug Aug 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant