Fix/windows compatibility #165
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
❌ Changes requested. Reviewed everything up to 5f57f4c in 22 seconds
More details
- Looked at
57lines of code in2files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. gptme/commands.py:25
- Draft comment:
Thechatfunction defined here is redundant and should be removed. - Reason this comment was not posted:
Marked as duplicate.
Workflow ID: wflow_rhFN59yCrqtvQLNd
Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
| if sys.platform != 'win32': | ||
| import termios | ||
|
|
||
| def chat(): |
There was a problem hiding this comment.
The chat function defined here is redundant and should be removed.
|
You would also need to add conditional code for windows everywhere that |
|
This diff looks messy, and doesn't come close to fixing the entire issue of native Windows/PowerShell support. Closing due to predicting it will go stale. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
Fix Windows compatibility by conditionally importing
termiosinchat.pyandcommands.py.termiosinchat.pyandcommands.pyfor non-Windows platforms to ensure compatibility.chat()function inchat.pyandcommands.py.This description was created by
for 5f57f4c. It will automatically update as commits are pushed.