feat: add system info to the about_user prompt #171

brayo-pip · 2024-10-08T13:16:45Z

Important

Adds system information to about_user prompt and introduces functions for system info retrieval in gptme/prompts.py.

Behavior:
- Adds system information to about_user prompt in prompt_user() in gptme/prompts.py.
- Introduces prompt_systeminfo() to generate system information prompt.
- Implements get_system_distro() to retrieve Linux distribution name.
Dependencies:
- Adds distro package to pyproject.toml for Linux distribution information.

^{This description was created by}^{for 9b4832f. It will automatically update as commits are pushed.}

ellipsis-dev

❌ Changes requested. Reviewed everything up to e610554 in 24 seconds

More details

Looked at 56 lines of code in 2 files
Skipped 1 files when reviewing.
Skipped posting 0 drafted comments based on config settings.

Workflow ID: wflow_r7F2rP7I7n2tl2kZ

Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

ellipsis-dev · 2024-10-08T13:17:17Z

gptme/prompts.py

+        version = os.uname().version
+    elif os.name == "nt":
+        distro = "Windows"
+        version = os.uname().version


os.uname() is not available on Windows. Consider using platform.version() or platform.release() for Windows version information.

brayo-pip · 2024-10-08T13:21:20Z

@ellipsis-dev do another review

ellipsis-dev

❌ Changes requested. Reviewed everything up to 2b1f6d6 in 28 seconds

More details

Looked at 60 lines of code in 2 files
Skipped 1 files when reviewing.
Skipped posting 0 drafted comments based on config settings.

Workflow ID: wflow_UV74QwS9w152cgUL

Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

ellipsis-dev · 2024-10-08T13:22:03Z

gptme/prompts.py

@@ -208,6 +210,21 @@ def prompt_tools(examples: bool = True) -> Generator[Message, None, None]:
    prompt += "\n\n*End of Tools List.*"
    yield Message("system", prompt.strip() + "\n\n")

+def get_system_info() -> str:


Consider adding exception handling in get_system_info() to manage potential errors when retrieving system information, such as when the distro package fails.

ErikBjare · 2024-10-08T13:26:03Z

pyproject.toml

@@ -28,6 +28,7 @@ tomlkit = "*"
 typing-extensions = "*"
 platformdirs = "^4.3"
 lxml = "*"
+distro = "*"


I don't think such simple checks justifies a dependency.

Just use platform, you can call out to lsb_release -d (if it exists on system) if you want specific distro.

@ErikBjare My system does not have lsb_release -d installed on default expecting more devices probably don't have installed by default. A workaround suggested is to read the contents of /etc/os-release

ErikBjare · 2024-10-08T13:30:52Z

gptme/prompts.py

@@ -143,7 +145,7 @@ def prompt_user() -> Generator[Message, None, None]:
    """
    config_prompt = get_config().prompt
    about_user = config_prompt.get(
-        "about_user", "You are interacting with a human programmer."
+        "about_user", f"You are interacting with a human programmer. I am running a {get_system_info()} system."


I don't think we want to add it to the user prompt like this.

I'd like the config to be platform-portable (I copy mine between machines), and this wouldn't work for users with an old config.

prompt_user is also not included in non-interactive mode, but it's useful in non-interactive mode too.

Maybe add a prompt_systeminfo?

brayo-pip · 2024-10-08T15:03:44Z

@ellipsis-dev review

ellipsis-dev

❌ Changes requested. Reviewed everything up to 8fcd414 in 39 seconds

More details

Looked at 62 lines of code in 1 files
Skipped 0 files when reviewing.
Skipped posting 0 drafted comments based on config settings.

Workflow ID: wflow_bdClyRn5lcCwgDO3

Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

ellipsis-dev · 2024-10-08T15:04:32Z

gptme/prompts.py

@@ -208,8 +211,39 @@ def prompt_tools(examples: bool = True) -> Generator[Message, None, None]:
    prompt += "\n\n*End of Tools List.*"
    yield Message("system", prompt.strip() + "\n\n")

+def prompt_systeminfo() -> Generator[Message, None, None]:
+    """Generate the system information prompt."""
+    if os.name == "posix":


The check for os.name == "darwin" is incorrect. os.name returns 'posix' for both Linux and macOS. Use platform.system() to differentiate between Linux and macOS.

ellipsis-dev · 2024-10-08T15:04:32Z

gptme/prompts.py

+
+    yield Message( "system", prompt,)
+
+def get_system_distro() -> str:


Consider using the distro package to get the system distribution name for better accuracy and maintainability.

brayo-pip · 2024-10-08T15:13:40Z

@ellipsis-dev review

ellipsis-dev

❌ Changes requested. Reviewed everything up to 9b4832f in 22 seconds

More details

Looked at 62 lines of code in 1 files
Skipped 0 files when reviewing.
Skipped posting 1 drafted comments based on config settings.

1. gptme/prompts.py:231

Draft comment:
Ensure consistent formatting for Message instantiation. Suggestion:

    yield Message("system", prompt)

Reason this comment was not posted:
Confidence changes required: 50%
The prompt_systeminfo function has inconsistent formatting for the Message instantiation.

Workflow ID: wflow_lo0xDiy22ebBOste

Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

ellipsis-dev · 2024-10-08T15:14:12Z

gptme/prompts.py

+
+def get_system_distro() -> str:
+    """Get the system distribution name."""
+    regex = r"^NAME=\"([^\"]+)\""


The regex pattern in get_system_distro is too specific. Consider using r'^NAME=("?)([^\n]+)\1$' to match entries with or without quotes.

ErikBjare · 2024-10-10T09:12:55Z

I just noticed/remembered I added this little line in the shell tool instructions to make it aware of macOS systems:

gptme/gptme/tools/shell.py

Line 53 in f258602

{'The platform is macOS.' if is_macos else ''}

ellipsis-dev bot reviewed Oct 8, 2024

View reviewed changes

brayo-pip force-pushed the master branch from e610554 to 2b1f6d6 Compare October 8, 2024 13:20

ellipsis-dev bot reviewed Oct 8, 2024

View reviewed changes

ErikBjare reviewed Oct 8, 2024

View reviewed changes

brayo-pip force-pushed the master branch 2 times, most recently from 397c091 to 8fcd414 Compare October 8, 2024 15:03

ellipsis-dev bot reviewed Oct 8, 2024

View reviewed changes

brayo-pip force-pushed the master branch from 8fcd414 to 9b4832f Compare October 8, 2024 15:12

ellipsis-dev bot reviewed Oct 8, 2024

View reviewed changes

brayo-pip force-pushed the master branch from 4a9d6e4 to a802350 Compare October 8, 2024 19:35

feat: create a system info prompt

ccc6d9b

brayo-pip force-pushed the master branch from a802350 to df07566 Compare October 8, 2024 19:35

fix: update the prompt

60f5360

brayo-pip force-pushed the master branch from df07566 to 60f5360 Compare October 8, 2024 20:23

ErikBjare mentioned this pull request Oct 10, 2024

feat: whitelist some commands #190

Draft

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: add system info to the about_user prompt #171

feat: add system info to the about_user prompt #171

brayo-pip commented Oct 8, 2024 •

edited by ellipsis-dev bot

Loading

ellipsis-dev bot left a comment

ellipsis-dev bot Oct 8, 2024

brayo-pip commented Oct 8, 2024

ellipsis-dev bot left a comment

ellipsis-dev bot Oct 8, 2024

ErikBjare Oct 8, 2024 •

edited

Loading

brayo-pip Oct 8, 2024

brayo-pip Oct 8, 2024

ErikBjare Oct 8, 2024 •

edited

Loading

brayo-pip commented Oct 8, 2024

ellipsis-dev bot left a comment

ellipsis-dev bot Oct 8, 2024

ellipsis-dev bot Oct 8, 2024

brayo-pip commented Oct 8, 2024

ellipsis-dev bot left a comment

ellipsis-dev bot Oct 8, 2024

ErikBjare commented Oct 10, 2024 •

edited

Loading


		yield Message( "system", prompt,)

		def get_system_distro() -> str:

feat: add system info to the about_user prompt #171

Are you sure you want to change the base?

feat: add system info to the about_user prompt #171

Conversation

brayo-pip commented Oct 8, 2024 • edited by ellipsis-dev bot Loading

ellipsis-dev bot left a comment

Choose a reason for hiding this comment

ellipsis-dev bot Oct 8, 2024

Choose a reason for hiding this comment

brayo-pip commented Oct 8, 2024

ellipsis-dev bot left a comment

Choose a reason for hiding this comment

ellipsis-dev bot Oct 8, 2024

Choose a reason for hiding this comment

ErikBjare Oct 8, 2024 • edited Loading

Choose a reason for hiding this comment

brayo-pip Oct 8, 2024

Choose a reason for hiding this comment

brayo-pip Oct 8, 2024

Choose a reason for hiding this comment

ErikBjare Oct 8, 2024 • edited Loading

Choose a reason for hiding this comment

brayo-pip commented Oct 8, 2024

ellipsis-dev bot left a comment

Choose a reason for hiding this comment

ellipsis-dev bot Oct 8, 2024

Choose a reason for hiding this comment

ellipsis-dev bot Oct 8, 2024

Choose a reason for hiding this comment

brayo-pip commented Oct 8, 2024

ellipsis-dev bot left a comment

Choose a reason for hiding this comment

ellipsis-dev bot Oct 8, 2024

Choose a reason for hiding this comment

ErikBjare commented Oct 10, 2024 • edited Loading

brayo-pip commented Oct 8, 2024 •

edited by ellipsis-dev bot

Loading

ErikBjare Oct 8, 2024 •

edited

Loading

ErikBjare Oct 8, 2024 •

edited

Loading

ErikBjare commented Oct 10, 2024 •

edited

Loading