Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

T3: [TODO merge with parent issue] Consensus VID integration macro task #1731

Closed
4 of 5 tasks
ggutoski opened this issue Sep 13, 2023 · 1 comment
Closed
4 of 5 tasks
Assignees

Comments

@ggutoski
Copy link
Contributor

ggutoski commented Sep 13, 2023

Why?

Currently VID work is split between the transactions task and the DA task, neither of which were intended for VID. If we continue to develop VID in this way then those two tasks will become an unholy mess. We need a separate VID task.

Currently VID does not have its own exchange. Instead we are re-using quorum exchange (in transactions task, pending #1864) and committee exchange (in DA task). But these exchanges were not intended for VID. Example: quorum exchange has a bunch of methods that are consensus-specific. (eg create_yes_message, create_no_message, create_timeout_message, etc.) Moreover, whichever exchange VID uses will need to offer some VID-specific methods. (eg create_vid_message, sign_vid_vote, etc). Currently these VID-specific methods have been added to the committee exchange. (Ugly!) But, as we know, VID should not use committee exchange in the future, so these VID-specific methods must be moved somewhere else eventually.

Subtasks

Old related issues?

Old issues. Not sure how relevant they still are.

@ggutoski ggutoski self-assigned this Sep 13, 2023
@ggutoski ggutoski mentioned this issue Sep 13, 2023
12 tasks
@ggutoski ggutoski changed the title T3: VID use quorum instead of committee T3: New task + exchange for VID Oct 5, 2023
@rob-maron rob-maron changed the title T3: New task + exchange for VID T3: Consensus VID integration macro task Oct 12, 2023
@ggutoski ggutoski added the vid label Nov 13, 2023
@ggutoski ggutoski changed the title T3: Consensus VID integration macro task T3: [TODO merge with parent issue] Consensus VID integration macro task Nov 15, 2023
@ggutoski
Copy link
Contributor Author

This issue is subsumed by #1583

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants