Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

respect Accept header #125

Open
jbearer opened this issue Sep 15, 2023 · 0 comments
Open

respect Accept header #125

jbearer opened this issue Sep 15, 2023 · 0 comments

Comments

@jbearer
Copy link
Member

jbearer commented Sep 15, 2023

  • currently we return html error messages in certain cases (eg url doesn't match any route) this is nice for experimentation but it makes automated clients harder to debug, as they will often discard the response body if it can't be parsed as json
  • we should always return a json object with the same shape when there is any error and the Accept header asks for json
  • in the browser, Accept will be unset or set to html, and we can still return friendly html
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant