Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review localization for new and existing controls #386

Open
7 tasks
nCastle1 opened this issue Nov 30, 2021 · 0 comments
Open
7 tasks

Review localization for new and existing controls #386

nCastle1 opened this issue Nov 30, 2021 · 0 comments

Comments

@nCastle1
Copy link
Contributor

nCastle1 commented Nov 30, 2021

SearchView has some strings baked into XAML & CS files that should be moved to .resx resources to improve localizability.

To do:

  • Update SearchView to follow existing localization pattern
  • Review other controls to ensure no other strings were missed
  • Review existing controls and test to ensure there aren't any issues with number formats, etc.
  • Update MeasureToolbar to use localized .resx resources for labels and units (changes needed in both .xaml templates and .cs code)
  • Update TimeSlider to use the system culture for displayed dates; currently the StringFormat-in-xaml approach has inconsistent results between versions of .NET Core, and hard-codes a Month-day-year format. See StackOverflow for details.
  • FeatureDataField uses the default TextBox behavior for editing dates/times. That behavior differs between UWP and WPF, and within WPF differs between .NET Core and .NET Framework. FeatureDataField should be updated to use an appropriate, localizing control for displaying and editing date/time fields. (duplicate of FeatureDataField: Show dates using a DatePicker or DatePickerTextbox #218)
  • FeatureDataField uses built-in .NET exception messages for some validation errors. Those are localized by default on WPF for .NET Framework, but not .NET Core. This control should be updated to use proper localized error messages that will work on all versions of .NET. Also, the method used for determining input language, as currently implemented, will always return "en-US", so that will need to be adjusted.
@nCastle1 nCastle1 mentioned this issue Nov 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant