Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dropdown]: unable conditionally render a dropdown on button click #11102

Open
2 of 6 tasks
svlesiv opened this issue Dec 18, 2024 · 0 comments
Open
2 of 6 tasks

[Dropdown]: unable conditionally render a dropdown on button click #11102

svlesiv opened this issue Dec 18, 2024 · 0 comments
Labels
0 - new New issues that need assignment. ArcGIS Site Scan Issues logged by ArcGIS Site Scan team members. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. calcite-components Issues specific to the @esri/calcite-components package. impact - p1 - need for current milestone User set priority impact status of p1 - need for current milestone needs triage Planning workflow - pending design/dev review.

Comments

@svlesiv
Copy link

svlesiv commented Dec 18, 2024

Check existing issues

Actual Behavior

To avoid loading dropdown content, we used an external trigger button that renders the dropdown only on a button click. It worked in v2.6.0, but starting from v2.7.0, it seems that clicking the external trigger button is treated as a click outside, causing the modal to close immediately.

Expected Behavior

The dropdown component would be displayed when clicking on a button (outside the dropdown) that changes the state of a variable to render the dropdown.

Screenshot 2024-12-18 at 12 52 22 PM

Reproduction Sample

https://codepen.io/svlesiv/pen/vEBxJgZ

Reproduction Steps

  1. Go to https://codepen.io/svlesiv/pen/vEBxJgZ codepen.
  2. Click on the External Trigger button.
  3. The dropdown will not be displayed for v2.7.0 - v2.13.2.

Reproduction Version

2.13.2

Relevant Info

No response

Regression?

2.6.0

Priority impact

impact - p1 - need for current milestone

Impact

Rendering a table with many dropdowns would again decrease the performance that was improved by https://github.com/ArcGIS/sitescan-manager/pull/7069 PR.

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-react
  • @esri/calcite-design-tokens
  • @esri/calcite-ui-icons
  • @esri/eslint-plugin-calcite-components

Esri team

ArcGIS Site Scan

@svlesiv svlesiv added 0 - new New issues that need assignment. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. needs triage Planning workflow - pending design/dev review. labels Dec 18, 2024
@github-actions github-actions bot added ArcGIS Site Scan Issues logged by ArcGIS Site Scan team members. calcite-components Issues specific to the @esri/calcite-components package. impact - p1 - need for current milestone User set priority impact status of p1 - need for current milestone labels Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 - new New issues that need assignment. ArcGIS Site Scan Issues logged by ArcGIS Site Scan team members. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. calcite-components Issues specific to the @esri/calcite-components package. impact - p1 - need for current milestone User set priority impact status of p1 - need for current milestone needs triage Planning workflow - pending design/dev review.
Projects
None yet
Development

No branches or pull requests

1 participant