Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Table / Table Row] Select / Deselect All / Clear affects disabled Table Rows #11143

Open
1 of 6 tasks
macandcheese opened this issue Dec 24, 2024 · 0 comments
Open
1 of 6 tasks
Labels
0 - new New issues that need assignment. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. c-table Issues that pertain to the calcite-table and related components Calcite (design) Issues logged by Calcite designers. design Issues that need design consultation prior to development. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone needs triage Planning workflow - pending design/dev review.

Comments

@macandcheese
Copy link
Contributor

macandcheese commented Dec 24, 2024

Check existing issues

Actual Behavior

Currently,disabled Table Rows can have their selected value changed by a user - either through the Select / Deselect All icon / Table Cell affordance or the Clear button.

Expected Behavior

I'd expect disabled rows to be unaffected by these select / de-seelct actions.

This could cause some odd UX - as these buttons may be interacted with and have no effect. For example, if there is one selected Table Row, and it happens to be disabled - the Clear button will (currently) still display and be interactive.

Would we want to hide, disable, or otherwise change the display of this or the "selection table cell", or explore other explanatory UI similar to "selected and out of view"? Perhaps the case of a single, selected, AND disabled Table Row not a common enough case to need to handle for now?

cc @ashetland @SkyeSeitz @matgalla for any UX thoughts on the above.

Reproduction Sample

https://codepen.io/mac_and_cheese/pen/qEWjrbe?editors=1000

Reproduction Steps

  1. Go to Codepen.
  2. Note that some Table Row are disabled and selected, or disabled and not selected.
  3. Use the built-in Table UI to select or deselect all.
  4. Note that the disabled Table Rows change selected state.

Reproduction Version

2.13.2

Relevant Info

No response

Regression?

No response

Priority impact

impact - p2 - want for an upcoming milestone

Impact

No response

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-react
  • @esri/calcite-design-tokens
  • @esri/calcite-ui-icons
  • @esri/eslint-plugin-calcite-components

Esri team

Calcite (design)

@macandcheese macandcheese added bug Bug reports for broken functionality. Issues should include a reproduction of the bug. design Issues that need design consultation prior to development. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. c-table Issues that pertain to the calcite-table and related components labels Dec 24, 2024
@github-actions github-actions bot added Calcite (design) Issues logged by Calcite designers. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone labels Dec 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 - new New issues that need assignment. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. c-table Issues that pertain to the calcite-table and related components Calcite (design) Issues logged by Calcite designers. design Issues that need design consultation prior to development. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone needs triage Planning workflow - pending design/dev review.
Projects
None yet
Development

No branches or pull requests

1 participant