Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release ESM build in dist #1338

Open
gavinr opened this issue Jul 12, 2022 · 2 comments
Open

Release ESM build in dist #1338

gavinr opened this issue Jul 12, 2022 · 2 comments
Assignees

Comments

@gavinr
Copy link
Contributor

gavinr commented Jul 12, 2022

Describe the problem

An ESM file is not included in the Esri Leaflet release:
https://unpkg.com/browse/[email protected]/dist/
... but would it be good if we did? I think this would allow users to import ESM directly from CDNs like Unpkg.

Describe the proposed solution

Leaflet releases an ESM build in their dist release. They started doing it at v1.3.2:

I have not looked into how they are generating it but I assume we could do a similar thing.

Alternatives considered

A workaround is to use the Skypack CDN like this: https://codepen.io/pen?template=wvoKwEv , but adding the ESM file ourselves would give added flexibility.

Additional Information

No response

@patrickarlt
Copy link
Contributor

This sounds good to me.

@gavinr gavinr self-assigned this Aug 2, 2022
@jgravois
Copy link
Contributor

jgravois commented Aug 2, 2022

at this point i don't even remember how far i got with it, but you can find some prior art here 🎨

https://github.com/Esri/esri-leaflet/tree/es / 9d90ea5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants