Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scale Full LN gaps w.r.t. current BPM #109

Open
Bestfast opened this issue Feb 26, 2023 · 2 comments
Open

Scale Full LN gaps w.r.t. current BPM #109

Bestfast opened this issue Feb 26, 2023 · 2 comments
Labels
Feature Request Adds an API, feature in the code

Comments

@Bestfast
Copy link
Contributor

Bestfast commented Feb 26, 2023

As the title suggests, in my opinion having it set to a dataframe would make the algorithm more flexible for chart generation and make FLN only a small piece of a chart. At the moment, the full LN algorithm uses a dataframe anyway for its operation, so I think it should be just a couple of lines to change it. Reference:

df = m.stack((HitList, HoldList))._stacked

main focus of this would be making custom algorithms based on full LN possible eg: having the gap set to a 1/4 of the current BPM of the chart, thing that is not possible (without having a lot of writes and splitting the chart for every bpm change) for multi-bpm charts.

@Bestfast Bestfast added the Feature Request Adds an API, feature in the code label Feb 26, 2023
@Eve-ning
Copy link
Owner

Hello, thanks for suggesting.
I originally made the full_ln signature only accept a Map to keep it clear on what's the expected input. I think having a DataFrame can be confusing as there's many ways to construct a DF from a Map.

Let me know a simple use-case and I'll see if I have any alternative solutions to it

@Eve-ning Eve-ning changed the title Full LN should take a dataframe of notes instead of a whole map Scale Full LN gaps w.r.t. current BPM Feb 26, 2023
@Eve-ning
Copy link
Owner

Updated the title to make it a higher level use-case

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Request Adds an API, feature in the code
Projects
None yet
Development

No branches or pull requests

2 participants