You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
As the title suggests, in my opinion having it set to a dataframe would make the algorithm more flexible for chart generation and make FLN only a small piece of a chart. At the moment, the full LN algorithm uses a dataframe anyway for its operation, so I think it should be just a couple of lines to change it. Reference:
main focus of this would be making custom algorithms based on full LN possible eg: having the gap set to a 1/4 of the current BPM of the chart, thing that is not possible (without having a lot of writes and splitting the chart for every bpm change) for multi-bpm charts.
The text was updated successfully, but these errors were encountered:
Hello, thanks for suggesting.
I originally made the full_ln signature only accept a Map to keep it clear on what's the expected input. I think having a DataFrame can be confusing as there's many ways to construct a DF from a Map.
Let me know a simple use-case and I'll see if I have any alternative solutions to it
Eve-ning
changed the title
Full LN should take a dataframe of notes instead of a whole map
Scale Full LN gaps w.r.t. current BPM
Feb 26, 2023
As the title suggests, in my opinion having it set to a dataframe would make the algorithm more flexible for chart generation and make FLN only a small piece of a chart. At the moment, the full LN algorithm uses a dataframe anyway for its operation, so I think it should be just a couple of lines to change it. Reference:
reamberPy/reamber/algorithms/generate/full_ln.py
Line 24 in e03d945
main focus of this would be making custom algorithms based on full LN possible eg: having the gap set to a 1/4 of the current BPM of the chart, thing that is not possible (without having a lot of writes and splitting the chart for every bpm change) for multi-bpm charts.
The text was updated successfully, but these errors were encountered: