Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve validation of ACCESS_CONTROL_TYPE settings for the FederatedMetastore #167

Open
patduin opened this issue Apr 29, 2019 · 3 comments

Comments

@patduin
Copy link
Contributor

patduin commented Apr 29, 2019

From the docs:

Primary metastores can configure access-control-type to have any of the described access-control-types whereas federated metastores may only be configured to READ_ONLY and READ_AND_WRITE_ON_DATABASE_WHITELIST.

The validation for these settings should be done on the configuration object com.hotels.bdp.waggledance.api.model.FederatedMetaStore. Instead currently the settings are validated in the com.hotels.bdp.waggledance.server.security.AccessControlHandlerFactory which isn't launched until a request made. Ideally WD shouldn't start if the configuration is wrong.

Acceptance Criteria:

  • WD doesn't start when the FederatedMetastore is configured with access_control_values: READ_AND_WRITE_AND_CREATE or READ_AND_WRITE_AND_CREATE_ON_DATABASE_WHITELIST.
@massdosage
Copy link
Contributor

We should take #153 and #154 into account while working on this. It might be useful to just fix this now but bear in mind it might no longer be needed (or will need to be implemented differently) if/when those tickets are worked on.

@massdosage
Copy link
Contributor

@patduin is this worth keeping open?

@patduin
Copy link
Contributor Author

patduin commented Feb 13, 2020

Would be nice to fix, but yeah time...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants