You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Primary metastores can configure access-control-type to have any of the described access-control-types whereas federated metastores may only be configured to READ_ONLY and READ_AND_WRITE_ON_DATABASE_WHITELIST.
The validation for these settings should be done on the configuration object com.hotels.bdp.waggledance.api.model.FederatedMetaStore. Instead currently the settings are validated in the com.hotels.bdp.waggledance.server.security.AccessControlHandlerFactory which isn't launched until a request made. Ideally WD shouldn't start if the configuration is wrong.
Acceptance Criteria:
WD doesn't start when the FederatedMetastore is configured with access_control_values: READ_AND_WRITE_AND_CREATE or READ_AND_WRITE_AND_CREATE_ON_DATABASE_WHITELIST.
The text was updated successfully, but these errors were encountered:
We should take #153 and #154 into account while working on this. It might be useful to just fix this now but bear in mind it might no longer be needed (or will need to be implemented differently) if/when those tickets are worked on.
From the docs:
The validation for these settings should be done on the configuration object
com.hotels.bdp.waggledance.api.model.FederatedMetaStore
. Instead currently the settings are validated in thecom.hotels.bdp.waggledance.server.security.AccessControlHandlerFactory
which isn't launched until a request made. Ideally WD shouldn't start if the configuration is wrong.Acceptance Criteria:
READ_AND_WRITE_AND_CREATE
orREAD_AND_WRITE_AND_CREATE_ON_DATABASE_WHITELIST
.The text was updated successfully, but these errors were encountered: