Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$1000] Jump to last unread chat when opening a report #35011

Open
6 tasks done
kbecciv opened this issue Jan 23, 2024 · 94 comments
Open
6 tasks done

[$1000] Jump to last unread chat when opening a report #35011

kbecciv opened this issue Jan 23, 2024 · 94 comments
Assignees
Labels
Engineering Internal Requires API changes or must be handled by Expensify staff NewFeature Something to build that is a new item. Reviewing Has a PR in review Weekly KSv2

Comments

@kbecciv
Copy link

kbecciv commented Jan 23, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 1.4.28.0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @MonilBhavsar
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1705558628672569

Action Performed:

  1. A is participant of a chat or room
  2. As another user send some good number of messages to chat report, so new messages can be scrolled up and down
  3. As user A, open the chat report

Expected Result:

The chat report view opens from where the messages are unread and user can scroll down

Actual Result:

The chat report view is scrolled down to the last message and user needs to scroll up to find last read message

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Recording.5931.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01fc144b2f2f5df388
  • Upwork Job ID: 1749920553887232000
  • Last Price Increase: 2024-06-11
  • Automatic offers:
    • ikevin127 | Contributor | 0
    • ishpaul777 | Contributor | 102670752
Issue OwnerCurrent Issue Owner: @roryabraham
@kbecciv kbecciv added Daily KSv2 Needs Reproduction Reproducible steps needed Bug Something is broken. Auto assigns a BugZero manager. labels Jan 23, 2024
Copy link

melvin-bot bot commented Jan 23, 2024

Triggered auto assignment to @trjExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@kbecciv kbecciv added External Added to denote the issue can be worked on by a contributor and removed Needs Reproduction Reproducible steps needed labels Jan 23, 2024
@melvin-bot melvin-bot bot changed the title Chat - When opening a chat with lots of unread messages user needs to scroll up to find last read message [$500] Chat - When opening a chat with lots of unread messages user needs to scroll up to find last read message Jan 23, 2024
Copy link

melvin-bot bot commented Jan 23, 2024

Job added to Upwork: https://www.upwork.com/jobs/~01fc144b2f2f5df388

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Jan 23, 2024
Copy link

melvin-bot bot commented Jan 23, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mollfpr (External)

@jeremy-croff
Copy link
Contributor

This PR #28793 specifically makes it scrolled to the bottom, seems like NAB

@trjExpensify
Copy link
Contributor

trjExpensify commented Jan 24, 2024

I'm a bit confused by the bug report @MonilBhavsar, so asking about it here. I thought this was something we'd implement via comment linking.

@roryabraham roryabraham changed the title [$500] Chat - When opening a chat with lots of unread messages user needs to scroll up to find last read message [HOLD #30269] [$500] Chat - When opening a chat with lots of unread messages user needs to scroll up to find last read message Jan 24, 2024
@roryabraham
Copy link
Contributor

HOLD for comment linking: #30269

@roryabraham roryabraham added NewFeature Something to build that is a new item. and removed Help Wanted Apply this label when an issue is open to proposals by contributors Bug Something is broken. Auto assigns a BugZero manager. labels Jan 24, 2024
Copy link

melvin-bot bot commented Jan 24, 2024

Current assignee @trjExpensify is eligible for the NewFeature assigner, not assigning anyone new.

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Daily KSv2 labels Jan 24, 2024
@melvin-bot melvin-bot bot added the Overdue label Feb 2, 2024
@trjExpensify
Copy link
Contributor

No change, still on hold Melv!

@melvin-bot melvin-bot bot removed the Overdue label Feb 5, 2024
@melvin-bot melvin-bot bot added the Overdue label Feb 13, 2024
@trjExpensify
Copy link
Contributor

Samesies, Melv!

@melvin-bot melvin-bot bot removed the Overdue label Feb 14, 2024
@melvin-bot melvin-bot bot added the Overdue label Feb 23, 2024
@trjExpensify
Copy link
Contributor

Still on hold, comment linking got held for the deploy freeze last week.

@melvin-bot melvin-bot bot removed the Overdue label Sep 16, 2024
@roryabraham roryabraham changed the title [HOLD #41153][$1000] Jump to last unread chat when opening a report [$1000] Jump to last unread chat when opening a report Sep 16, 2024
@melvin-bot melvin-bot bot added the Overdue label Sep 25, 2024
@ishpaul777
Copy link
Contributor

ishpaul777 commented Sep 29, 2024

not sure about next steps here, i see we got the BE PRs merged #41153 (comment)

@roryabraham
Copy link
Contributor

roryabraham commented Oct 4, 2024

Going on parental leave, going to reassign this to another Expensify engineer for the remainder.

@melvin-bot melvin-bot bot removed the Overdue label Oct 4, 2024
@roryabraham roryabraham removed their assignment Oct 4, 2024
@roryabraham roryabraham added Engineering Internal Requires API changes or must be handled by Expensify staff and removed Internal Requires API changes or must be handled by Expensify staff labels Oct 4, 2024
@rlinoz rlinoz self-assigned this Oct 4, 2024
@roryabraham
Copy link
Contributor

Thanks @rlinoz

@rlinoz
Copy link
Contributor

rlinoz commented Oct 11, 2024

@janicduplessis can I assign you to this one?

@janicduplessis
Copy link
Contributor

@rlinoz Yes!

@janicduplessis
Copy link
Contributor

@rlinoz Is there a way I can test what you mentioned here? I can look at the issues you encountered and then it sounds like this would be solved.

@rlinoz
Copy link
Contributor

rlinoz commented Oct 16, 2024

@janicduplessis just sent you a DM with how to access that

@rlinoz
Copy link
Contributor

rlinoz commented Oct 25, 2024

We have draft PRs for backend and frontend

@melvin-bot melvin-bot bot removed the Overdue label Oct 25, 2024
@ishpaul777
Copy link
Contributor

PR still in WIP, @janicduplessis Any updates?

@janicduplessis
Copy link
Contributor

The PR is mostly working already, but there is an edge case that will require some refactoring of ReportActionsView / ReportActionsList so we can reuse the logic to start the list at a specific reportActionID. I will work on this in a separate PR to avoid making the current one giant.

@janicduplessis
Copy link
Contributor

Have a new PR up to refactor how we handle opening the list at a specific index. Before it was mixed with the comment linking code and now it is extracted out to BaseInvertedFlatList so it will make it easy to use for opening the report at last unread message too.

#52149, currently in draft, will test more and complete checklist later today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Engineering Internal Requires API changes or must be handled by Expensify staff NewFeature Something to build that is a new item. Reviewing Has a PR in review Weekly KSv2
Projects
Status: In Progress
Development

No branches or pull requests