Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy Checklist: New Expensify 2024-04-26 #41122

Closed
63 tasks done
github-actions bot opened this issue Apr 26, 2024 · 16 comments
Closed
63 tasks done

Deploy Checklist: New Expensify 2024-04-26 #41122

github-actions bot opened this issue Apr 26, 2024 · 16 comments
Assignees
Labels
Daily KSv2 🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging StagingDeployCash

Comments

@github-actions
Copy link
Contributor

github-actions bot commented Apr 26, 2024

Release Version: 1.4.67-7
Compare Changes: production...staging

This release contains changes from the following pull requests:

Deploy Blockers:

Deployer verifications:

  • I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
  • I checked Firebase Crashlytics and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.
  • I checked GitHub Status and verified there is no reported incident with Actions.

cc @Expensify/applauseleads

@mountiny mountiny added the 🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging label Apr 26, 2024
@mountiny
Copy link
Contributor

@Expensify/applauseleads ready to test

@kbecciv
Copy link

kbecciv commented Apr 27, 2024

TR is 45% left

#40010 is failing with original KI #38773, left comment #40010 (comment)
#40369 is failing with original KI #40369 on Web, left comment #40369 (comment), and failing on IOS with #41142
#40675 - pending verification on mWeb
#40701 - pending verification on mWeb
#40868 - pending verification on Desktop
#40942 is failing with #40942 (comment)
#40987 is failing with original KI #38497 on Android app, left comment #40987 (comment)
#41006 - pending verification on IOS app

@kbecciv
Copy link

kbecciv commented Apr 28, 2024

TR is 20% left

#40010 is failing with original KI #38773, left comment #40010 (comment)
#40369 is failing with original KI #40369 on Web, left comment #40369 (comment), and failing on IOS with #41142
#40701 - pending verification on mWeb
#40942 is failing with #40942 (comment)
#40987 is failing with original KI #38497 on Android app, left comment #40987 (comment)
#41006 is failing with #41129 on Web, Desktop and IOS app

@thienlnam
Copy link
Contributor

Demoting #41134

@thienlnam
Copy link
Contributor

Demoting #41138

@Julesssss
Copy link
Contributor

Checked off #41128 as a blocker

@kbecciv
Copy link

kbecciv commented Apr 29, 2024

Regression is completed!

#40010 is failing with original KI #38773, left comment #40010 (comment)
#40369 is failing with original KI #40369 on Web, left comment #40369 (comment), and failing on IOS with #41142
#40701 is failing with #41128 on Web, Android and IOS app; and it's failing with #41128 and #41170 on mWeb and Desktop.
#40942 is failing with #40942 (comment)
#40987 is failing with original KI #38497 on Android app, left comment #40987 (comment)
#41006 is failing with #41129 on Web, Desktop and IOS app.

Deploy Blockers:
#41129
#41130
#41132
#41133
#41135
#41142
#41148
#41157
#41170
#41184
#41195

@francoisl
Copy link
Contributor

Checking off #41135, non blocker and there's a follow-up PR in review already.

@thienlnam
Copy link
Contributor

Demoting #41129, behind a beta

@francoisl
Copy link
Contributor

Revert for #41133 tested on staging, checking off

@MonilBhavsar
Copy link
Contributor

Checking of #41170 , CP'ed fix to staging

@francoisl
Copy link
Contributor

#41200 tested on staging, checking off

@francoisl
Copy link
Contributor

Checking #40942 as the issue is in the backend

@francoisl
Copy link
Contributor

Checking #41142, tested on staging

@francoisl
Copy link
Contributor

:shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Daily KSv2 🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging StagingDeployCash
Projects
None yet
Development

No branches or pull requests

7 participants