[Held requests] Approve modal does not appear when one of the expense is held

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number:
Reproducible in staging?: Needs reproduction
Reproducible in production?: Needs reproduction
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @puneetlath
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1714845351600779

Deliverable

Provide reliable reproduction steps for the bug below. All assignees must be able to reproduce using the steps to be compensated.

Action Performed:

1. Go to staging.new.expensify.com
2. As an employee submit multiple expenses with scanned receipts
3. Login as approver and open the report
4. Put one scanned expense on hold
5. Navigate to another report and navigate back to the original report
6. Approve the report

NOTE: step 5 is just to forcefully trigger OpenReport which resets the transaction's hold state. The video in OP did not do the same but somehow it might trigger OpenReport (when and where to call this API are quite unreliable and we're working on it).

Expected Result:

Modal prompt to decide to approve the held or unheld total

Actual Result:

No modal displayed and both expense got approved.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Screen.Recording.2024-05-04.at.1.47.18.PM.mov

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @AndrewGable

[melvin-bot]

Triggered auto assignment to @stephanieelliott (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[MelvinBot]

This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989

[stephanieelliott]

I'm not able to reproduce this, adding the label to get it on the weekly retest rotation.

[puneetlath]

I experience it about 50% of the time when I try to approve with held expenses.

[mvtglobally]

Issue not reproducible during KI retests. (First week)

[stephanieelliott]

Still trying to repro, I think there is a proposal in the works to create jobs for these so will keep an eye there bc I do think this is worth fixing.

[melvin-bot]

@stephanieelliott this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[melvin-bot]

Unable to auto-create job on Upwork. The BZ team member should create it manually for this issue.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @eh2077 (External)

[mallenexpensify]

Updated title with prefix [$125 Reproducible Steps]
Updated OP to inc.

Deliverable

Provide reliable reproduction steps for the bug below. All assignees must be able to reproduce using the steps to be compensated.

Using this as a test issue for

• https://github.com/Expensify/Expensify/issues/398280

[stephanieelliott]

^^ using this issue to test drive the new process for Create jobs for “Needs Reproduction” issues to document reproducible steps.

[gijoe0295]

Proposal

Reproducible steps:

1. Submit multiple expenses with scan expenses
2. Put one scan expense on hold
3. Navigate to another report and navigate back to the expense report
4. Approve the expense report

I guess this has the same root cause with #40829 as I mentioned in #40829 (comment). That issue is still reproducible:

This is a backend issue, OpenReport API resets all the transaction's comment.

Note that step 3 is just to forcefully trigger OpenReport which resets the transaction's hold state. The video in OP did not do the same but somehow it might trigger OpenReport (when and where to call this API are quite unreliable and we're working on it).

[mvtglobally]

Issue not reproducible during KI retests. (Second week)

[gijoe0295]

@eh2077 Could you review the reproduce steps above ^?

[robertjchen]

Just getting to this now, update shortly

[robertjchen]

So, the reason we were holding off is that it's tangentially related to the optimistic changes from: #42573

We encountered this during testing there and needed to get those changes out to better isolate the issue.

[melvin-bot]

@robertjchen, @stephanieelliott, @eh2077 Eep! 4 days overdue now. Issues have feelings too...

[melvin-bot]

@robertjchen, @stephanieelliott, @eh2077 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

[robertjchen]

Getting to this one before EOW, was focused on clearing out the other held issues raised this week.

[robertjchen]

Started looking into this on the backend over the weekend, was unable to pinpoint the source as the flows don't reveal anything obvious that would cause this discrepancy. Investigation continues!

[melvin-bot]

@robertjchen, @stephanieelliott, @eh2077 Whoops! This issue is 2 days overdue. Let's get this updated quick!

[robertjchen]

Reproduced again here: https://expensify.slack.com/archives/C05LX9D6E07/p1723143340548779

[robertjchen]

Potentially it would be a frontend fix- it seems like we're not optimistically updating that report/expense (preview?) such that we prevent immediate approval after the hold action

Though, I wonder if we wait long enough at the last step- eventually that preview becomes held? If so, that means the backend is okay and we can just focus on the frontend.

[melvin-bot]

@robertjchen, @stephanieelliott, @eh2077 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[robertjchen]

Confirming if it's backend or frontend or both

[robertjchen]

Slack Discussion here. We have a backend fix being deployed for this!

[robertjchen]

The fix just went out! Let's re-test this

[puneetlath]

I confirmed it seems to be fixed for me. Let's make sure we get a new regression test for this scenario with scanning receipts @stephanieelliott

[robertjchen]

Awesome, any other remaining steps here before we can close this one out?

[stephanieelliott]

@isagoico created the QA test for us ❤️ https://github.com/Expensify/Expensify/issues/421472

Seems we're all set to close now!