Duplicates - Edited duplicate show "Review required" when there is no error or violation

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Bug was found when validating #40153
Version Number: 1.4.81-8
Reproducible in staging?: y
Reproducible in production?: no
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:

Action Performed:

. Go to staging.new.expensify.com
2. Go to workspace chat.
3. Submit two scan expenses with the same receipt (so that they will be flagged as duplicate).
4. Wait for both scanning to complete.
5. Go to expense report (make sure both expenses have the "Duplicate" label)
6. Go to transaction thread of one of the expenses.
7. Change the amount so that both expenses are no longer duplicate.
8. Return to expense report.

Expected Result:

The edited expense will not have "Review required" label, if there is no error message or violation in the transaction thread.

Actual Result:

The edited expense shows "Review required" label, but there is no error message or violation in the transaction thread.

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6509423_1718114254702.20240611_213817.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @Christinadobrzyn (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @tylerkaraszewski (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[m-natarajan]

@tylerkaraszewski FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[m-natarajan]

We think that this bug might be related to #wave-collect - Release 2

[luacmartins]

I don't think we need to block the deploy on this, since clicking into the request shows no errors. I agree that it needs to be solved though. Maybe @cead22 has more context on this one.

[cead22]

@m-natarajan please always include the reportIDs/transactionIDs so we're not transcribing them from videos. It looks like the transactionID in the video is 4360400970679580180. Can you share the onyx data in the transactionViolations_4360400970679580180 please, or for the other transaction showing RBR?

cc @pecanoro since you know more about duplicates

[pecanoro]

This is totally expected. The violation is clearly stated in the HOLD section of the transaction; it says there is a violation that needs to be fixed. The Review Duplicates part is being implemented. This is all under a beta so it should be fine, closing!