[$250] [HOLD for payment 2024-07-22] Expense - Blank area below report header in the expense report

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.0.2-0
Reproducible in staging?: Y
Reproducible in production?: N
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

1. Go to staging.new.expensify.com
2. Go to FAB > Submit expense > Manual.
3. Submit expense to any user that has no unsettled expense.
4. Go to transaction thread.

Expected Result:

There will be no blank area below the report header.

Actual Result:

There is small blank area below the report header.
This issue only happens in expense report.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6524811_1719378867306.20240626_131015.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~012b0cf135dfea0be9
• Upwork Job ID: 1815882500753303517
• Last Price Increase: 2024-07-23

[melvin-bot]

Triggered auto assignment to @alexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @MariaHCD (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[izarutskaya]

@alexpensify I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

[izarutskaya]

We think this issue might be related to the #collect project.

[etCoderDysto]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Blank area below report header in the expense report

What is the root cause of that problem?

We are adding padding of styles.pb3 in MoneyReportHeader here

App/src/components/MoneyReportHeader.tsx

Line 378 in 57e5d0e

<View style={[isMoreContentShown && [styles.dFlex, styles.flexColumn, styles.borderBottom], styles.ph5, styles.pb3, styles.gap3]}>

What changes do you think we should make in order to solve the problem?

Remove styles.pb3 from View style

What alternative solutions did you explore? (Optional)

[etCoderDysto]

The issue is introduced by this PR. I can raise a quick pr if the author is not available at the time.

[tienifr]

Investigating.

[MariaHCD]

Thanks, @tienifr. This is a minor UI bug so I don't necessarily think this should block the deploy. Do you think otherwise, @tienifr?

[tienifr]

@MariaHCD Agree. I'll raise PR in several hours.

[alexpensify]

@tienifr any update here? Thanks!

[alexpensify]

I believe the payment date has been moved to 7/22, and will prepare accordingly.

[alexpensify]

To prepare for the payment process, I believe that this UI update is a dupe of #39989. I asked the BZ team assigned to that GH for feedback.

[melvin-bot]

Payment Summary

Upwork Job

• Reviewer: @tienifr owed $250 via NewDot

BugZero Checklist (@alexpensify)

• I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct

[alexpensify]

I'll work on the payment process tomorrow.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~012b0cf135dfea0be9

[melvin-bot]

Current assignee @dukenv0307 is eligible for the External assigner, not assigning anyone new.

[alexpensify]

Payouts due: 2024-07-22

• Contributor: $250 @tienifr
• Contributor+: $250 @dukenv0307

The Upwork job is here. I noticed @dukenv0307 was part of the review process for this GH. Please accept, and I can proceed with the next steps. Thanks!

[AirTechWick]

Is this job done I am looking for work to do?

[melvin-bot]

📣 @AirTechWick! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Make sure you've read and understood the contributing guidelines.
2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[alexpensify]

@AirTechWick - Yes, sorry for the confusion. The recent tag updates addressed payment.

[alexpensify]

@dukenv0307 - please accept the invite in Upwork. After, I can complete the payment process. Thanks!

[alexpensify]

No update yet in Upwork.

[dukenv0307]

@alexpensify Sorry for the delay, I accepted the UW offer

Thank you!

[alexpensify]

Thank you! I've completed the payment process in Upwork and updated the payment summary -

#44434 (comment)

@tienifr, please submit a request in Chat-- thanks!

[JmillsExpensify]

$250 approved for @tienifr