Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AWAITING PAYMENT] [$250] iOS- Public room- RHP not opens smoothly after selecting any option from room details #44812

Closed
1 of 6 tasks
izarutskaya opened this issue Jul 4, 2024 · 68 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor

Comments

@izarutskaya
Copy link

izarutskaya commented Jul 4, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 9.0.4.0
Reproducible in staging?: Y
Reproducible in production?: N
Found when executing PR : #43985
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

  1. Log out ND if user is logged in
  2. Navigate to a public room, e.g. https://staging.new.expensify.com/r/4865807136424891
  3. Tap the header to open the details
  4. Select any option

Expected Result:

The RHP (sign-in modal) opens smoothly

Actual Result:

The sign-in modal does not open smoothly, opening slows down when the modal almost gets to the left edge.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6532639_1720058699150.IMG_7964.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @
Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01176fb78ce72c5cfa
  • Upwork Job ID: 1811805082507741105
  • Last Price Increase: 2024-08-23
  • Automatic offers:
    • wildan-m | Contributor | 103702844
Issue OwnerCurrent Issue Owner: @sobitneupane
@izarutskaya izarutskaya added DeployBlockerCash This issue or pull request should block deployment Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. DeployBlocker Indicates it should block deploying the API labels Jul 4, 2024
Copy link

melvin-bot bot commented Jul 4, 2024

Triggered auto assignment to @garrettmknight (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

Copy link

melvin-bot bot commented Jul 4, 2024

Triggered auto assignment to @nkuoch (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Jul 4, 2024
Copy link
Contributor

github-actions bot commented Jul 4, 2024

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@izarutskaya
Copy link
Author

@garrettmknight FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

@izarutskaya
Copy link
Author

We think this issue might be related to the #vip-vsb

@izarutskaya
Copy link
Author

Production

RPReplay_Final1720075961.MP4

@garrettmknight garrettmknight removed DeployBlockerCash This issue or pull request should block deployment DeployBlocker Indicates it should block deploying the API labels Jul 4, 2024
@garrettmknight
Copy link
Contributor

Don't think this needs to be a deploy blocker. I'm going to open it up to be external to start.

@garrettmknight garrettmknight added External Added to denote the issue can be worked on by a contributor Daily KSv2 and removed Hourly KSv2 labels Jul 4, 2024
Copy link

melvin-bot bot commented Jul 4, 2024

Unable to auto-create job on Upwork. The BZ team member should create it manually for this issue.

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Jul 4, 2024
Copy link

melvin-bot bot commented Jul 4, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @sobitneupane (External)

Copy link

melvin-bot bot commented Jul 9, 2024

@garrettmknight, @nkuoch, @sobitneupane Huh... This is 4 days overdue. Who can take care of this?

@melvin-bot melvin-bot bot added the Overdue label Jul 9, 2024
@sobitneupane
Copy link
Contributor

Waiting for proposal.

@melvin-bot melvin-bot bot removed the Overdue label Jul 10, 2024
Copy link

melvin-bot bot commented Aug 27, 2024

📣 @wildan-m 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Daily KSv2 labels Aug 28, 2024
@wildan-m
Copy link
Contributor

@sobitneupane I've created the PR.

The desktop and android mweb videos isn't uploaded yet.

Desktop: I am unsure how to open a deeplink on desktop before logging in. Asking it here:
https://expensify.slack.com/archives/C01GTK53T8Q/p1724826778770759

Android mWeb: Public room not opened, the link always re-directed to login page.

@wildan-m
Copy link
Contributor

@sobitneupane the desktop and android videos has been uploaded.

I use deeplinking for desktop by setting window.location.href = '/r/4865807136424891' in the console tab, as explained in the PR for the desktop test step.

@melvin-bot melvin-bot bot added Monthly KSv2 and removed Weekly KSv2 labels Sep 20, 2024
Copy link

melvin-bot bot commented Sep 20, 2024

This issue has not been updated in over 15 days. @garrettmknight, @nkuoch, @wildan-m, @sobitneupane eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

@wildan-m
Copy link
Contributor

@MelvinBot it hit production 7 days ago. we can close this issue

@garrettmknight garrettmknight added the Awaiting Payment Auto-added when associated PR is deployed to production label Sep 24, 2024
@garrettmknight
Copy link
Contributor

Payment Summary:

@sobitneupane please complete the checklist and request payment

@garrettmknight garrettmknight added Daily KSv2 and removed Monthly KSv2 labels Sep 24, 2024
@garrettmknight garrettmknight changed the title [$250] iOS- Public room- RHP not opens smoothly after selecting any option from room details [AWAITING PAYMENT] [$250] iOS- Public room- RHP not opens smoothly after selecting any option from room details Sep 24, 2024
@melvin-bot melvin-bot bot added Daily KSv2 and removed Daily KSv2 labels Sep 30, 2024
@garrettmknight
Copy link
Contributor

@sobitneupane please complete the checklist.

@sobitneupane
Copy link
Contributor

Regression Test Proposal

  1. Log out ND if user is logged in
  2. Navigate to a public room
  3. Tap the header to open the details
  4. Select any option
  5. Verify that the sign-in modal(RHP) opens smoothly.

Do we agree 👍 or 👎

Copy link

melvin-bot bot commented Oct 9, 2024

@garrettmknight, @nkuoch, @wildan-m, @sobitneupane Whoops! This issue is 2 days overdue. Let's get this updated quick!

Copy link

melvin-bot bot commented Oct 11, 2024

@garrettmknight, @nkuoch, @wildan-m, @sobitneupane Eep! 4 days overdue now. Issues have feelings too...

Copy link

melvin-bot bot commented Oct 15, 2024

@garrettmknight, @nkuoch, @wildan-m, @sobitneupane Now this issue is 8 days overdue. Are you sure this should be a Daily? Feel free to change it!

@garrettmknight garrettmknight removed the Reviewing Has a PR in review label Oct 15, 2024
@melvin-bot melvin-bot bot added the Overdue label Oct 15, 2024
@garrettmknight
Copy link
Contributor

Closing - @sobitneupane submit for payment when you're ready.

@trjExpensify
Copy link
Contributor

Confirming the payment summary here is correct: #44812 (comment)

@garrettmknight
Copy link
Contributor

$250 approved for @sobitneupane

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor
Projects
No open projects
Development

No branches or pull requests

8 participants