[HOLD for payment 2024-08-29] [$250] [Search v2.1] Update search parser grammar to handle special characters

[luacmartins]

Problem

Coming from here, the search parser grammar doesn't handle some special characters very well, for example it throws an error when ; is added to a text input like keyword

Solution

Update the parser grammar to correctly handle special characters:

; should be treated like any other character
(whitespace) should be a logic AND operator when separating filter keys, e.g. amount:200 category:travel means amount=200 AND category=travel. It should also be a logical OR when separating free text, e.g. las vegas means keyword=las OR keyword=vegas
, is used as a logical OR operator when separating values for a filter key, e.g. category:travel,hotel,food means category=travel OR category=hotel OR category=food. It should also be treated as a regular character when used in free text, e.g. las, vegas means keyword="las," OR keyword="vegas"

cc @Kicu @adamgrzybowski @289Adam289 @Guccio163 @SzymczakJ

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01cfdc085a6131060b
• Upwork Job ID: 1821628463273416803
• Last Price Increase: 2024-08-08
• Automatic offers:
• ikevin127 | Reviewer | 103492420

Issue Owner

Current Issue Owner: @

Issue Owner

Current Issue Owner: @slafortune

[melvin-bot]

Triggered auto assignment to @slafortune (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01cfdc085a6131060b

[melvin-bot]

Current assignee @ikevin127 is eligible for the External assigner, not assigning anyone new.

[289Adam289]

Hi! I am from SWM and I'd like to work on this issue.

[melvin-bot]

📣 @ikevin127 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[289Adam289]

After investigation, I believe that implementing the following part of the proposed solution:

; should be treated like any other character

will resolve this issue.
The 'Page Not Found' appears to be caused by a SyntaxError in the SearchParser.

[melvin-bot]

📣 @MCarlesso! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Make sure you've read and understood the contributing guidelines.
2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[MCarlesso]

Contributor details
Your Expensify account email: [email protected]
Upwork Profile Link: https://www.upwork.com/freelancers/~012c16fe40faf63452

[melvin-bot]

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

[luacmartins]

Thanks for the proposal @MCarlesso However, we already have someone working on this issue.

[MCarlesso]

Sorry @luacmartins! I'm new here 🙂 From reading the contribution guidelines I thought that only complete proposals would be considered? 😅 I don't see an approved proposal for this one yet?

[luacmartins]

No worries! You're correct that that's the regular process. This issue is part of the Search project though and we have an expert agency working with us on this implementation, so they are handling most of the Search issues.

[slafortune]

This is being worked on, it will have a 7-day regression period, so I don't feel the need to add another BZ person to this.
I'll be out until 8/21 and will check in on this then.

[289Adam289]

HI! @luacmartins How to handle cases where keywords are provided in multiple places in an input string. For example:
xxx yyy category:Cat merchant:Mer zzz
in #47328 it is is handled like that:
(xxx OR yyy OR zzz) AND (category:Cat) AND (merchant:Mer)
but I am not sure if this is correct approach.

[luacmartins]

Yea, that's correct!

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.23-0 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Search parser grammar update #47328

If no regressions arise, payment will be issued on 2024-08-29. 🎊

For reference, here are some details about the assignees on this issue:

• @ikevin127 requires payment automatic offer (Reviewer)
• @289Adam289 does not require payment (Contractor)

[melvin-bot]

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@ikevin127] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
• [@slafortune] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

[slafortune]

@ikevin127 can you please propose a regression test?

[ikevin127]

@slafortune I've asked (ref1, ref2, ref3) whether regression tests are needed on Search v2.1 related issues and was told (ref1, ref2, ref3) that regression tests will be added later as part of the project wrap up.

[slafortune]

@ikevin127 Role c+ - Paid $250 via Upworks
@289Adam289 Role Contributor - does not require payment (Contractor)