[$250] [Advanced Approval Workflows] Should display empty state when the member list is empty

[dylanexpensify]

Coming from this project, we have this follow-up polish issue we need to complete where we should display an empty state when the member list is empty. More details here.

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01040daf30f3152600
• Upwork Job ID: 1825862440438169741
• Last Price Increase: 2024-08-20

Issue Owner

Current Issue Owner: @

[dylanexpensify]

cc @blazejkustra

[blazejkustra]

Hey! I’m Błażej Kustra from Software Mansion, an expert agency, and I’d like to work on this issue!

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01040daf30f3152600

[melvin-bot]

Current assignee @DylanDylann is eligible for the External assigner, not assigning anyone new.

[dylanexpensify]

Hi @blazejkustra! It's all yours!

[blazejkustra]

Let's agree with one approach for a case when member list is empty @Expensify/design @JmillsExpensify.

357329520-d1237c4d-2f70-4174-a773-ca123271d0e4.mov

I like the idea from @dannymcclain here. But, let's settle on a particular message to display.

[DylanDylann]

In this comment, @dannymcclain suggested: "Hey, all your members are part of approval workflows already! Right on. Everyone is getting approved. Way to go."

@blazejkustra I think we can confirm with the design team one more time after the implementation on the PR phase

[JmillsExpensify]

Yes, I think that should work. For clarity, we're also not going to show a search input in this case correct? Basically since there is nothing to search for.

As for the message, @jamesdeanexpensify you might want to weigh in on the copy. I think we could probably tweak Danny's suggestion a bit, e.g. "All workspace members belong to an approval workflow. Nice work, everyone is accounted for."

[jamesdeanexpensify]

Maybe switching the order a bit:

Nice job! All workspace members belong to an approval workflow.

[JmillsExpensify]

Love it.

[blazejkustra]

All yours @DylanDylann

#47848

[melvin-bot]

Triggered auto assignment to @jasperhuangg, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[melvin-bot]

This issue has not been updated in over 15 days. @jasperhuangg, @blazejkustra, @DylanDylann eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[DylanDylann]

@jasperhuangg Please help process the payment for me. Thanks

[melvin-bot]

Triggered auto assignment to @isabelastisser (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[jasperhuangg]

Strange that no BugZero person was assigned, apologies for the delay @DylanDylann.

@isabelastisser Do you mind processing payment for @DylanDylann and @blazejkustra? It looks like @blazejkustra is owed $250 for implementing the solution to this issue, and @DylanDylann is owed for proposal and PR reviews.

[DylanDylann]

@blazejkustra comes from SWM, we only need to process payment for me

[isabelastisser]

Reviewing this now.

[isabelastisser]

@DylanDylann's offer was sent in Upwork. All set!

[DylanDylann]

@isabelastisser Offer accepted, thanks 🙏