[HOLD for payment 2024-10-24] [$250] Track - User appears with offline avatar on Submit expense page for distance request #48476

lanitochka17 · 2024-09-03T13:54:13Z

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

Version Number: 9.0.28-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4913193&group_by=cases:section_id&group_id=309130&group_order=asc
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause - Internal Team

Action Performed:

Go to self DM.
Click + > Track expense > Distance.
From actionable whisper select Submit it to someone> Add user's email address
Take a look at user's avatar photo

Expected Result:

User should be displayed with default/custom avatar photo

Actual Result:

User appears with offline avatar on Submit expense page for distance request

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence

Bug6591566_1725358268612.Recording__3856.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~021832021050151052347
Upwork Job ID: 1832021050151052347
Last Price Increase: 2024-10-01
Automatic offers:

FitseTLT | Contributor | 104300205

Issue Owner

Current Issue Owner: @zanyrenney

melvin-bot · 2024-09-03T13:54:23Z

Triggered auto assignment to @zanyrenney (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

lanitochka17 · 2024-09-03T13:54:46Z

@zanyrenney FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

daledah · 2024-09-03T14:26:16Z

Proposal

Please re-state the problem that we are trying to solve in this issue.

User appears with offline avatar on Submit expense page for distance request

What is the root cause of that problem?

We don't want to include the p2p option if it's distance request in

App/src/pages/iou/request/MoneyRequestParticipantsSelector.tsx

Line 113 in 094953f

    
           (canUseP2PDistanceRequests || iouRequestType !== CONST.IOU.REQUEST_TYPE.DISTANCE) && !isCategorizeOrShareAction,

What changes do you think we should make in order to solve the problem?

Solution 1. We shouldn't show the Submit to someone option if it's distance request
Solution 2. We can adjust the condition here to include p2p if it's DM report

What alternative solutions did you explore? (Optional)

FitseTLT · 2024-09-03T20:52:54Z

Edited by proposal-police: This proposal was edited at 2024-09-03 20:55:23 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Track - User appears with offline avatar on Submit expense page for distance request

What is the root cause of that problem?

We are passing includeP2P false here

App/src/pages/iou/request/MoneyRequestParticipantsSelector.tsx

Line 113 in e60b821

    
           (canUseP2PDistanceRequests || iouRequestType !== CONST.IOU.REQUEST_TYPE.DISTANCE) && !isCategorizeOrShareAction,

so all p2p/dm reports are filtered out and the user is only being added as a new invitee/userToInvite, hence the offline avatar.

What changes do you think we should make in order to solve the problem?

Because we are allowing P2P distance request when it is submitted from tracked expense we need to include P2P for action SUBMIT so change it to

            (canUseP2PDistanceRequests || action === CONST.IOU.ACTION.SUBMIT || iouRequestType !== CONST.IOU.REQUEST_TYPE.DISTANCE) && !isCategorizeOrShareAction,

What alternative solutions did you explore? (Optional)

Because we currently allow p2p distance request when canUseP2PDistanceRequests we can also hide the submit to someone actionable when it is a distance request and canUseP2PDistanceRequests is false (beta disabled)

App/src/pages/home/report/ReportActionItem.tsx

Lines 425 to 432 in fc33ac1

    
           return [ 
        
               { 
        
                   text: 'actionableMentionTrackExpense.submit', 
        
                   key: `${action.reportActionID}-actionableMentionTrackExpense-submit`, 
        
                   onPress: () => { 
        
                       ReportUtils.createDraftTransactionAndNavigateToParticipantSelector(transactionID ?? '0', report.reportID, CONST.IOU.ACTION.SUBMIT, action.reportActionID); 
        
                   }, 
        
                   isMediumSized: true,

    const {canUseP2PDistanceRequests} = usePermissions();
return [
                ...(!isDistanceRequest(getTransaction(transactionID)) || canUseP2PDistanceRequests
                    ? [
                          {
                              text: 'actionableMentionTrackExpense.submit',
                              key: `${action.reportActionID}-actionableMentionTrackExpense-submit`,
                              onPress: () => {
                                  ReportUtils.createDraftTransactionAndNavigateToParticipantSelector(transactionID ?? '0', report.reportID, CONST.IOU.ACTION.SUBMIT, action.reportActionID);
                              },
                              isMediumSized: true,
                          },
                      ]
                    : []),

melvin-bot · 2024-09-06T11:40:31Z

Job added to Upwork: https://www.upwork.com/jobs/~021832021050151052347

melvin-bot · 2024-09-06T11:40:36Z

Triggered auto assignment to Contributor-plus team member for initial proposal review - @abdulrahuman5196 (External)

zanyrenney · 2024-09-06T11:40:43Z

adding external to get a contributor to take a look at the propsals.

melvin-bot · 2024-09-09T18:29:32Z

@abdulrahuman5196, @zanyrenney Whoops! This issue is 2 days overdue. Let's get this updated quick!

melvin-bot · 2024-09-11T18:06:54Z

@abdulrahuman5196, @zanyrenney Eep! 4 days overdue now. Issues have feelings too...

abdulrahuman5196 · 2024-09-11T18:17:25Z

Checking now

FitseTLT · 2024-09-11T18:45:03Z

Updated to add alternative approach

zanyrenney · 2024-09-13T15:34:34Z

bump @abdulrahuman5196 can you review please?

melvin-bot · 2024-09-13T16:00:21Z

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

melvin-bot · 2024-09-16T18:18:04Z

@abdulrahuman5196, @zanyrenney Huh... This is 4 days overdue. Who can take care of this?

abdulrahuman5196 · 2024-09-17T15:41:21Z

@zanyrenney What is the expectation here? I am only getting no results found on searching anything. Should we disable the Submit to someone for distance requests as contributors suggestion? Or something else is the expectation?

Screen.Recording.2024-09-17.at.9.09.29.PM.mov

melvin-bot · 2024-09-17T18:00:11Z

@abdulrahuman5196 @zanyrenney this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

zanyrenney · 2024-09-20T08:18:07Z

just tried again and can't repro this, so going to close.

FitseTLT · 2024-10-07T12:39:47Z

@abdulrahuman5196 PR ready

melvin-bot · 2024-10-17T01:44:36Z

Reviewing label has been removed, please complete the "BugZero Checklist".

melvin-bot · 2024-10-17T01:44:40Z

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.49-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

Fix - Track - User appears with offline avatar on Submit expense page for distance request #50331

If no regressions arise, payment will be issued on 2024-10-24. 🎊

For reference, here are some details about the assignees on this issue:

@FitseTLT requires payment automatic offer (Contributor)
@abdulrahuman5196 requires payment through NewDot Manual Requests

melvin-bot · 2024-10-17T01:44:41Z

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@abdulrahuman5196] The PR that introduced the bug has been identified. Link to the PR:
[@abdulrahuman5196] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@abdulrahuman5196] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@abdulrahuman5196] Determine if we should create a regression test for this bug.
[@abdulrahuman5196] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@zanyrenney] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

zanyrenney · 2024-10-24T08:47:49Z

payment summary

@FitseTLT requires payment automatic offer (Contributor) - paid $250 on upwork
@abdulrahuman5196 requires payment through NewDot Manual Requests - please request $250 on ND.

zanyrenney · 2024-10-24T08:48:04Z

We don't need a regression test here.

tgolen · 2024-10-24T16:39:04Z

@zanyrenney Why shouldn't this one get a regression test? Also, can you and @abdulrahuman5196 please fill out and complete the BZ checklist?

zanyrenney · 2024-10-24T18:08:16Z

Why shouldn't this one get a regression test?

I thought it was spotted in a testrail session from the OP, so it is already covered in TestRail.

https://expensify.testrail.io/index.php?/suites/view/14084&group_by=cases:section_id&group_order=asc&display_deleted_cases=0&group_id=319503

Is that incorrect? @tgolen

zanyrenney · 2024-10-24T18:08:48Z

Definitely can update the checklist though! @abdulrahuman5196 please can you add the answers on this

zanyrenney · 2024-10-25T09:18:55Z

bump @abdulrahuman5196 please complete the checklist

abdulrahuman5196 · 2024-10-25T11:32:49Z

Why shouldn't this one get a regression test?

I thought it was spotted in a testrail session from the OP, so it is already covered in TestRail.

https://expensify.testrail.io/index.php?/suites/view/14084&group_by=cases:section_id&group_order=asc&display_deleted_cases=0&group_id=319503

Is that incorrect? tgolen

I also thought this. Anyways will complete checklist

abdulrahuman5196 · 2024-10-25T11:34:18Z

The PR that introduced the bug has been identified. Link to the PR:

I don't think a specific PR caused this issue. Could be due to different changes made between projects.

The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:

N/A

A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:

N/A since couldn't be covered part of reviewer checklist.

Determine if we should create a regression test for this bug.

Yes.

If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

Go to self DM.
Click + > Track expense > Distance.
Verify that the actionable whisper of the expense created in (2) has no Submit it to someone option/button (unless you enable P2P Beta)

zanyrenney · 2024-10-25T13:44:20Z

Hey @abdulrahuman5196 mind doing this in the correct format from the checklist please? You have missed a bunch of the questions out.

zanyrenney · 2024-10-25T13:44:54Z

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@abdulrahuman5196] The PR that introduced the bug has been identified. Link to the PR: I don't think a specific PR caused this issue. Could be due to different changes made between projects.
[@abdulrahuman5196] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: N/A
[@abdulrahuman5196] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A since couldn't be covered part of reviewer checklist.
[@abdulrahuman5196] Determine if we should create a regression test for this bug. Yes - linked
[@abdulrahuman5196] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again. - Done.
[@zanyrenney] Link the GH issue for creating/updating the regression test once above steps have been agreed upon: Open a regression test for 48476 #51469

abdulrahuman5196 · 2024-10-25T14:30:49Z

Hi, Updated the checklist.

zanyrenney · 2024-10-25T14:47:01Z

Complete!

JmillsExpensify · 2024-10-29T14:08:19Z

$250 approved for @abdulrahuman5196

lanitochka17 added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Sep 3, 2024

melvin-bot bot assigned zanyrenney Sep 3, 2024

melvin-bot bot added the Overdue label Sep 5, 2024

zanyrenney added the External Added to denote the issue can be worked on by a contributor label Sep 6, 2024

melvin-bot bot changed the title ~~Track - User appears with offline avatar on Submit expense page for distance request~~ [$250] Track - User appears with offline avatar on Submit expense page for distance request Sep 6, 2024

melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Sep 6, 2024

melvin-bot bot assigned abdulrahuman5196 Sep 6, 2024

melvin-bot bot removed the Overdue label Sep 6, 2024

melvin-bot bot added the Overdue label Sep 9, 2024

melvin-bot bot removed the Overdue label Sep 11, 2024

melvin-bot bot added the Overdue label Sep 16, 2024

melvin-bot bot removed the Overdue label Sep 17, 2024

melvin-bot bot added Weekly KSv2 and removed Daily KSv2 labels Oct 7, 2024

melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Oct 17, 2024

melvin-bot bot changed the title ~~[$250] Track - User appears with offline avatar on Submit expense page for distance request~~ [HOLD for payment 2024-10-24] [$250] Track - User appears with offline avatar on Submit expense page for distance request Oct 17, 2024

melvin-bot bot removed the Reviewing Has a PR in review label Oct 17, 2024

melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Oct 23, 2024

zanyrenney closed this as completed Oct 24, 2024

tgolen reopened this Oct 24, 2024

zanyrenney mentioned this issue Oct 25, 2024

Open a regression test for 48476 #51469

Open

zanyrenney closed this as completed Oct 25, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[HOLD for payment 2024-10-24] [$250] Track - User appears with offline avatar on Submit expense page for distance request #48476

[HOLD for payment 2024-10-24] [$250] Track - User appears with offline avatar on Submit expense page for distance request #48476

lanitochka17 commented Sep 3, 2024 •

edited by melvin-bot bot

Loading

melvin-bot bot commented Sep 3, 2024

lanitochka17 commented Sep 3, 2024

daledah commented Sep 3, 2024

FitseTLT commented Sep 3, 2024 •

edited

Loading

melvin-bot bot commented Sep 6, 2024

melvin-bot bot commented Sep 6, 2024

zanyrenney commented Sep 6, 2024

melvin-bot bot commented Sep 9, 2024

melvin-bot bot commented Sep 11, 2024

abdulrahuman5196 commented Sep 11, 2024

FitseTLT commented Sep 11, 2024

zanyrenney commented Sep 13, 2024

melvin-bot bot commented Sep 13, 2024

melvin-bot bot commented Sep 16, 2024

abdulrahuman5196 commented Sep 17, 2024

melvin-bot bot commented Sep 17, 2024

zanyrenney commented Sep 20, 2024

FitseTLT commented Oct 7, 2024

melvin-bot bot commented Oct 17, 2024

melvin-bot bot commented Oct 17, 2024

melvin-bot bot commented Oct 17, 2024

zanyrenney commented Oct 24, 2024

zanyrenney commented Oct 24, 2024

tgolen commented Oct 24, 2024

zanyrenney commented Oct 24, 2024 •

edited

Loading

zanyrenney commented Oct 24, 2024

zanyrenney commented Oct 25, 2024

abdulrahuman5196 commented Oct 25, 2024

abdulrahuman5196 commented Oct 25, 2024 •

edited

Loading

zanyrenney commented Oct 25, 2024 •

edited

Loading

zanyrenney commented Oct 25, 2024 •

edited

Loading

abdulrahuman5196 commented Oct 25, 2024

zanyrenney commented Oct 25, 2024

JmillsExpensify commented Oct 29, 2024

[HOLD for payment 2024-10-24] [$250] Track - User appears with offline avatar on Submit expense page for distance request #48476

[HOLD for payment 2024-10-24] [$250] Track - User appears with offline avatar on Submit expense page for distance request #48476

Comments

lanitochka17 commented Sep 3, 2024 • edited by melvin-bot bot Loading

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

melvin-bot bot commented Sep 3, 2024

lanitochka17 commented Sep 3, 2024

daledah commented Sep 3, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

FitseTLT commented Sep 3, 2024 • edited Loading

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

melvin-bot bot commented Sep 6, 2024

melvin-bot bot commented Sep 6, 2024

zanyrenney commented Sep 6, 2024

melvin-bot bot commented Sep 9, 2024

melvin-bot bot commented Sep 11, 2024

abdulrahuman5196 commented Sep 11, 2024

FitseTLT commented Sep 11, 2024

zanyrenney commented Sep 13, 2024

melvin-bot bot commented Sep 13, 2024

melvin-bot bot commented Sep 16, 2024

abdulrahuman5196 commented Sep 17, 2024

melvin-bot bot commented Sep 17, 2024

zanyrenney commented Sep 20, 2024

FitseTLT commented Oct 7, 2024

melvin-bot bot commented Oct 17, 2024

melvin-bot bot commented Oct 17, 2024

melvin-bot bot commented Oct 17, 2024

zanyrenney commented Oct 24, 2024

zanyrenney commented Oct 24, 2024

tgolen commented Oct 24, 2024

zanyrenney commented Oct 24, 2024 • edited Loading

zanyrenney commented Oct 24, 2024

zanyrenney commented Oct 25, 2024

abdulrahuman5196 commented Oct 25, 2024

abdulrahuman5196 commented Oct 25, 2024 • edited Loading

zanyrenney commented Oct 25, 2024 • edited Loading

zanyrenney commented Oct 25, 2024 • edited Loading

abdulrahuman5196 commented Oct 25, 2024

zanyrenney commented Oct 25, 2024

JmillsExpensify commented Oct 29, 2024

lanitochka17 commented Sep 3, 2024 •

edited by melvin-bot bot

Loading

FitseTLT commented Sep 3, 2024 •

edited

Loading

zanyrenney commented Oct 24, 2024 •

edited

Loading

abdulrahuman5196 commented Oct 25, 2024 •

edited

Loading

zanyrenney commented Oct 25, 2024 •

edited

Loading

zanyrenney commented Oct 25, 2024 •

edited

Loading