Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy Checklist: New Expensify 2024-09-03 #48515

Closed
68 tasks done
github-actions bot opened this issue Sep 3, 2024 · 17 comments
Closed
68 tasks done

Deploy Checklist: New Expensify 2024-09-03 #48515

github-actions bot opened this issue Sep 3, 2024 · 17 comments
Assignees
Labels
🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging StagingDeployCash

Comments

@github-actions
Copy link
Contributor

github-actions bot commented Sep 3, 2024

Release Version: 9.0.29-12
Compare Changes: production...staging

This release contains changes from the following pull requests:

Deploy Blockers:

Deployer verifications:

  • I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
  • I checked Firebase Crashlytics and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.
  • I checked GitHub Status and verified there is no reported incident with Actions.

cc @Expensify/applauseleads

@mvtglobally mvtglobally added the 🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging label Sep 3, 2024
@OSBotify
Copy link
Contributor

OSBotify commented Sep 4, 2024

🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/9.0.29-0 🚀

@mountiny
Copy link
Contributor

mountiny commented Sep 4, 2024

demoted #48530

@lakchote
Copy link
Contributor

lakchote commented Sep 4, 2024

demoted #48543 for reasons mentioned here.

@mountiny
Copy link
Contributor

mountiny commented Sep 4, 2024

demoted #48531 as its very minor ui issue

@mvtglobally
Copy link

Regression:
TCs - 80% completed

PRs:
#47628 - Pending validation on iOS
#47827 - Pending validation on iOS and Desktop
#47848 - issue repro on Android an iOs only with #48531
#47983 -Pending validation on iOS
#48155 - Pending validation on Android and iOS
#48180 - Pending validation on all platforms
#48385 - Pending validation on all platforms
#48403 - Failing on mWeb, Desktop, Android wit #48240

Blockers:
#48528
#48533
#48535
#48536
#48540
#48542
#48544
#48549
#48550
#48554

@mountiny
Copy link
Contributor

mountiny commented Sep 4, 2024

demoted #48542

@roryabraham
Copy link
Contributor

#48528 is fixed on staging, checking it off

@neil-marcellini
Copy link
Contributor

#48565 is a very small issue only for iOS with a specific system font size, so not a blocker.

@isagoico
Copy link

isagoico commented Sep 4, 2024

Checked off #48556 as it was a pass
#48537 is still failing - #48537 (comment)

@mvtglobally
Copy link

Regression:
TCs - 98% completed

PRs:

#47827 - is failing with #48540 on Desktop
#48180 - Pending validation on mWeb and Android
#48385 - is failing with #48555. checking off
#48403 - Failing on mWeb, Desktop, Android with #48240
Checking CPs

Blockers:

#48533
#48535
#48536
#48540
#48580
#48587

@mvtglobally
Copy link

Regression is completed

PRs:

#47827 - is failing with #48540 on Desktop
#48180 - Pending validation on mWeb and Android. This PR needs phone enabled travel account and we are not able to validate. Can you check these internally?
#48403 - Failing on mWeb, Desktop, Android with #48240
#48537 - Pending validation on all platforms
#48546 - Pending validation on Android

Blockers:

#48533
#48535
#48536
#48540
#48580
#48587

@mountiny
Copy link
Contributor

mountiny commented Sep 5, 2024

demoted #48644

@mvtglobally
Copy link

Checked off new CPs

@francoisl
Copy link
Contributor

Demoted #48659

@roryabraham
Copy link
Contributor

#47827 had a number of issues, but they've all been fixed or demoted, so I'm checking it off

@luacmartins
Copy link
Contributor

Tested #48403. It's a pass

@roryabraham
Copy link
Contributor

:shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging StagingDeployCash
Projects
None yet
Development

No branches or pull requests

10 participants