[HOLD for payment 2024-10-31][$250] Rules - After disabling all workflow features and opening rules, page keep loading

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.0.31-12
Reproducible in staging?: Y
Reproducible in production?: N
Issue was found when executing this PR: #47468
Issue reported by: Applause Internal Team

Action Performed:

1. Go to https://staging.new.expensify.com/home
2. Go to profile icon - workspace-- new workspace
3. Tap more features-- enable workflows
4. Disable all workflow features
5. Tap more features -- enable rules
6. Tap rules

Expected Result:

After disabling all workflow features and opening rules, page must not load and it must display content.

Actual Result:

After disabling all workflow features and opening rules, page keep loading.

Workaround:

Unknown

Platforms:

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6598681_1725973188332.Screenrecorder-2024-09-10-14-29-35-379_compress_1.1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021833585257948581733
• Upwork Job ID: 1833585257948581733
• Last Price Increase: 2024-09-10

Issue Owner

Current Issue Owner: @strepanier03

[melvin-bot]

Triggered auto assignment to @strepanier03 (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @luacmartins (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[Nodebrute]

Edited by proposal-police: This proposal was edited at 2024-09-10 14:36:41 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

After disabling all workflow features and opening rules, page keep loading

What is the root cause of that problem?

We set default value true to shouldShowLoading here

What changes do you think we should make in order to solve the problem?

We should pass shouldShowLoading={false} here

App/src/pages/workspace/rules/PolicyRulesPage.tsx

Line 32 in 286b945

<WorkspacePageWithSections

Solution 2(Golbal Fix)
We can use && here instead of ||

(isLoading && firstRender.current) 

What alternative solutions did you explore? (Optional)

We should pass showLoadingAsFirstRender false

App/src/pages/workspace/rules/PolicyRulesPage.tsx

Line 32 in 286b945

<WorkspacePageWithSections

[nkdengineer]

Proposal

Please re-state the problem that we are trying to solve in this issue.

After disabling all workflow features and opening rules, page keep loading.

What is the root cause of that problem?

currently, we set default shouldShowLoading=true here and not set value for shouldShowLoading props in component PolicyRulesPage

App/src/pages/workspace/WorkspacePageWithSections.tsx

Line 128 in 989d3ce

shouldShowLoading = true,

What changes do you think we should make in order to solve the problem?

We should pass value for 2 props shouldShowLoading and isLoading here like we did with WorkspaceWorkflowsPage here

    const isLoading = !!(policy?.isLoading && policy?.reimbursementChoice === undefined);

    <WorkspacePageWithSections
     ...
     isLoading={isLoading}
     shouldShowLoading={isLoading}
    >

App/src/pages/workspace/rules/PolicyRulesPage.tsx

Lines 32 to 41 in 989d3ce

	<WorkspacePageWithSections
	testID={PolicyRulesPage.displayName}
	shouldUseScrollView
	headerText={translate('workspace.common.rules')}
	guidesCallTaskID={CONST.GUIDES_CALL_TASK_IDS.WORKSPACE_RULES}
	shouldShowOfflineIndicatorInWideScreen
	route={route}
	icon={Illustrations.Rules}
	shouldShowNotFoundPage={!canUseWorkspaceRules}
	>

What alternative solutions did you explore? (Optional)

[luacmartins]

@Nodebrute you're proposal looks good. Are you available to work on a PR now?

[Nodebrute]

@luacmartins yes.

[Nodebrute]

@luacmartins I can open a PR now.

[luacmartins]

Great. All yours

[luacmartins]

This is fixed in staging

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021833585257948581733

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @jjcoffee (External)

[melvin-bot]

@strepanier03, @luacmartins, @Nodebrute Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[melvin-bot]

@strepanier03, @luacmartins, @Nodebrute Eep! 4 days overdue now. Issues have feelings too...

[melvin-bot]

@strepanier03, @luacmartins, @Nodebrute 8 days overdue is a lot. Should this be a Weekly issue? If so, feel free to change it!

[melvin-bot]

@strepanier03, @luacmartins, @Nodebrute 10 days overdue. I'm getting more depressed than Marvin.

[melvin-bot]

This issue has not been updated in over 14 days. @strepanier03, @luacmartins, @Nodebrute eroding to Weekly issue.

[melvin-bot]

This issue has not been updated in over 15 days. @strepanier03, @luacmartins, @Nodebrute eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[melvin-bot]

Payment Summary

Upwork Job

• ROLE: @Nodebrute paid $250 via Upwork (offer)

BugZero Checklist (@strepanier03)

• I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1833585257948581733/hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct

[Nodebrute]

Hey, @luacmartins The PR was merged on September 10th, so I think it might be ready for payment now.

[luacmartins]

Bump @strepanier03

[strepanier03]

Been ooo since Thursday until today, handling now.

[strepanier03]

@Nodebrute - I sent you an offer in Upwork. I'll pay it once I see it's accepted.

[Nodebrute]

@strepanier03 Accepted.

[strepanier03]

@Nodebrute do we need a reg test for this?