Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy Checklist: New Expensify 2024-09-17 #49356

Closed
40 tasks done
github-actions bot opened this issue Sep 17, 2024 · 25 comments
Closed
40 tasks done

Deploy Checklist: New Expensify 2024-09-17 #49356

github-actions bot opened this issue Sep 17, 2024 · 25 comments
Assignees
Labels
🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging StagingDeployCash

Comments

@github-actions
Copy link
Contributor

github-actions bot commented Sep 17, 2024

Release Version: 9.0.37-4
Compare Changes: production...staging

This release contains changes from the following pull requests:

Deploy Blockers:

Deployer verifications:

  • I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
  • I checked Firebase Crashlytics and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.
  • I checked GitHub Status and verified there is no reported incident with Actions.

cc @Expensify/applauseleads

@kavimuru kavimuru added the 🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging label Sep 17, 2024
@OSBotify
Copy link
Contributor

🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/9.0.37-0 🚀

@m-natarajan
Copy link

Regression is at 15% progress
Unchecked PRs:
#47997 Pending validation in android
#48026 Pending validation in web mweb and desktop
#48141 Pending validation in Android and iOS
#48182 Pending validation in Android and iOS
#48277 Pending validation in all platforms
#48398 Pending validation in Desktop and Android
#48601 Pending validation in all platforms
#48759 Pending validation in all platforms
#48767 Pending validation in all platforms
#48532 #48532 (comment)
#49029 Pending validation in Android and iOS
#49041 Pending validation in all platforms
#49158 Pending validation in all platforms
#49236 Pending validation in mWeb Android and iOS

@m-natarajan
Copy link

Regression is 20% left
Unchecked PRs:
#48277 Failing with #49372
#48601 Pending validation in iOS and Android
#48767 Pending validation in all but Web
#48532 Pending validation in all platforms
#49158 Pending validation in all platforms
#49370 Pending validation in all platforms
Blockers:

#49371
#49372
#49378
#49383

@grgia
Copy link
Contributor

grgia commented Sep 18, 2024

Checking off #49378 - CP here #49384

@grgia
Copy link
Contributor

grgia commented Sep 18, 2024

demoted #49371

@grgia
Copy link
Contributor

grgia commented Sep 18, 2024

#49383 was demoted

@grgia
Copy link
Contributor

grgia commented Sep 18, 2024

demoted #49372

@grgia
Copy link
Contributor

grgia commented Sep 18, 2024

demoted #49386

@grgia
Copy link
Contributor

grgia commented Sep 18, 2024

@m-natarajan could you give an update on where you're at with the regression tests

@grgia
Copy link
Contributor

grgia commented Sep 18, 2024

image

This is the only new crash. Android and only affected 1 user

@grgia
Copy link
Contributor

grgia commented Sep 18, 2024

Waiting on regression tests to complete

@m-natarajan
Copy link

m-natarajan commented Sep 18, 2024

@grgia Regression is 3% left
Unchecked PRs:
#48277 Failing with #49372
#48601 Pending validation in Web and Android
#48767 Pending validation in mWeb Desktop iOS
#48532 Failing in web with KI #46615, Repro in Prod, Checking it off
#49384 CP- Pending validation in wen mWeb Android iOS

@grgia
Copy link
Contributor

grgia commented Sep 18, 2024

Could not reproduce #49392 so I demoted

@grgia
Copy link
Contributor

grgia commented Sep 18, 2024

@m-natarajan could you give an update on the regression tests?

@m-natarajan
Copy link

@grgia
Regression is left with 17 steps.

Unchecked PR
#48767 Pending validation in mWeb Desktop iOS
#48277 Failing with #49372

@m-natarajan
Copy link

m-natarajan commented Sep 18, 2024

@grgia Regression completed
Unchecked PR
#48277 Failing with #49372

@grgia
Copy link
Contributor

grgia commented Sep 18, 2024

Thank you @m-natarajan !

@grgia
Copy link
Contributor

grgia commented Sep 18, 2024

Checking off #48277 as this is an internal bug #49372

@grgia
Copy link
Contributor

grgia commented Sep 18, 2024

Checklist is complete, gonna kick-off deploy

@grgia
Copy link
Contributor

grgia commented Sep 18, 2024

@AndrewGable is gonna take over deploy since we cherry picked one https://expensify.slack.com/archives/C07J32337/p1726690825146829

@AndrewGable
Copy link
Contributor

:shipit:

@os-botify os-botify bot reopened this Sep 18, 2024
@os-botify
Copy link

os-botify bot commented Sep 18, 2024

This issue either has unchecked items or has not yet been marked with the :shipit: emoji of approval.
Reopening!

Copy link

melvin-bot bot commented Sep 18, 2024

📣 @os-botify[bot]! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

  1. Make sure you've read and understood the contributing guidelines.
  2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
  3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
  4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
    Screen Shot 2022-11-16 at 4 42 54 PM
    Format:
Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

@AndrewGable
Copy link
Contributor

Oops let me check Firebase!

@AndrewGable
Copy link
Contributor

:shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging StagingDeployCash
Projects
None yet
Development

No branches or pull requests

6 participants