[HOLD for payment 2024-10-29] [$250] [Dupe Detection] Unable to resolve duplicates on one-expense reporrts

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.0.40-1
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @JmillsExpensify
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1727339112704349

Action Performed:

1. Create a new workspace, upgrade to Control
2. Make sure you’re on the duplicate detection beta
3. Enabled delayed submission with a weekly frequency. Enable approvals (with you as the approver)
4. Have user a submit a report, with the merchant McDonalds for $50. Approve the report
5. Have the user create another expense report for the same merchant and amount (McDonalds and $50)
6. Have the user submit the report

Expected Result:

The approver is able to resolve a duplicate

Actual Result:

The approver is unable to resolve the duplicate, as no resolve duplicate button appears

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021839321413603387914
• Upwork Job ID: 1839321413603387914
• Last Price Increase: 2024-09-26

Issue Owner

Current Issue Owner: @sobitneupane

[melvin-bot]

Triggered auto assignment to @dylanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[daledah]

Edited by proposal-police: This proposal was edited at 2024-09-26 15:28:39 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

The approver is unable to resolve the duplicate, as no resolve duplicate button appears

What is the root cause of that problem?

New feature

What changes do you think we should make in order to solve the problem?

In MoneyReportHeader use isDuplicate to detect the duplicated transaction same as what we did in MoneyRequestHeader

then show the Review duplicates button in here

    const isDuplicate = TransactionUtils.isDuplicate(transaction?.transactionID ?? '');

...

{isDuplicate && !shouldUseNarrowLayout && (
                        <Button
                            success
                            text={translate('iou.reviewDuplicates')}
                            style={[styles.p0, styles.ml2]}
                            onPress={() => {
                                Navigation.navigate(ROUTES.TRANSACTION_DUPLICATE_REVIEW_PAGE.getRoute(transactionThreadReport?.reportID ?? '', Navigation.getReportRHPActiveRoute()));
                            }}
                        />
                    )}

...
{isDuplicate && shouldUseNarrowLayout && (
                    <View style={[styles.ph5, styles.pb3]}>
                        <Button
                            success
                            text={translate('iou.reviewDuplicates')}
                            style={[styles.w100, styles.pr0]}
                            onPress={() => {
                                Navigation.navigate(ROUTES.TRANSACTION_DUPLICATE_REVIEW_PAGE.getRoute(transactionThreadReport?.reportID ?? '', Navigation.getReportRHPActiveRoute()));
                            }}
                        />
                    </View>
                )}

We should add the marginRight if there's at least one button on the right side

What alternative solutions did you explore? (Optional)

Result

Screen.Recording.2024-10-02.at.10.21.36.mov

[dannymcclain]

One way we could handle this is by adding a Resolve duplicates button to the header, like so:

cc @JmillsExpensify @Expensify/design

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021839321413603387914

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @sobitneupane (External)

[JmillsExpensify]

Nice, I like that idea!

[daledah]

Updated proposal to fit with the new design

[dubielzyk-expensify]

Same. Looks good to me

[shubham1206agra]

Am I missing something or one expense should auto resolve duplicates? What are we marking duplicate against?

[pecanoro]

@shubham1206agra The duplicates might be in a different report

[sobitneupane]

Thanks for the proposal @daledah

We should remove canUseDupeDetection check in

I am not sure how is the change related to this issue. Dupe Detection is behind beta and the function is serving the purpose.

Can you please add more details to the 2nd point in your proposal.

[daledah]

@sobitneupane Thanks for your feedback, I updated the proposal to add more details and video result

[dylanexpensify]

@sobitneupane thoughts now?

[sobitneupane]

Thanks for the proposal @daledah

We would prefer not to display the 'Resolve Duplicate' button in the Expense Report that contains several "batched" expenses, as shown in the Result section of your proposal.

Currently, we already display the 'Resolve Duplicate' button within a transaction for Expense Report that contains several "batched" expenses. However, when there is only one expense, the button is not shown. The only page where we would like to add the 'Resolve Duplicate' button is:

Expected UI: #49793 (comment)

[sobitneupane]

@dannymcclain Should we use the text "Review duplicates" instead of "Resolve duplicate", since that is the term currently being used? #49793 (comment)

[dannymcclain]

Should we use the text "Review duplicates" instead of "Resolve duplicate", since that is the term currently being used?

This is a good question for @JmillsExpensify — I'm tempted to say let's use the language we already have, but I'm not 100% sure.

[pecanoro]

Yeah, let's keep the language that we already have, no need to change it for now.

[dylanexpensify]

@daledah when can we expect updated proposal?

[daledah]

@dylanexpensify @sobitneupane
Sorry, I misunderstood the requirement.

I updated the proposal. Pls let me know what your though?

[sobitneupane]

Thanks for the update, @daledah.

The proposal from @daledah looks good to me. However, we still need some styling changes to achieve the requested UI.

🎀 👀 🎀 C+ reviewed

[melvin-bot]

Current assignee @pecanoro is eligible for the choreEngineerContributorManagement assigner, not assigning anyone new.

[pecanoro]

Assigning @daledah to the issue!

[melvin-bot]

Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[dylanexpensify]

Reassigning as I head to parental leave next week! Thanks Matt!

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.51-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix: resolve dupe button on one-expense report #50133

If no regressions arise, payment will be issued on 2024-10-29. 🎊

For reference, here are some details about the assignees on this issue:

• @sobitneupane requires payment through NewDot Manual Requests
• @daledah requires payment (Needs manual offer from BZ)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@sobitneupane] The PR that introduced the bug has been identified. Link to the PR:
• [@sobitneupane] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@sobitneupane] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@sobitneupane] Determine if we should create a regression test for this bug.
• [@sobitneupane] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@mallenexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[melvin-bot]

Payment Summary

Upwork Job

• Reviewer: @sobitneupane owed $250 via NewDot
• ROLE: @daledah paid $(AMOUNT) via Upwork (LINK)

BugZero Checklist (@mallenexpensify)

• I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1839321413603387914/hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct

[melvin-bot]

@pecanoro, @mallenexpensify, @sobitneupane, @daledah Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[melvin-bot]

@pecanoro, @mallenexpensify, @sobitneupane, @daledah Still overdue 6 days?! Let's take care of this!

[mallenexpensify]

@daledah , can you please accept the job and reply here once you have?
https://www.upwork.com/jobs/~021853927916382654201

@sobitneupane , plz fill out the BZ checklist above, I imagine we want a test case for this

[daledah]

@mallenexpensify Many thanks, job accepted

[sobitneupane]

Regression Test Proposal

1. Create an expense report and submit it in a control workspace.
2. Create another report with the same amount and merchant as step 1.
3. Open the expense report submitted in step 2
4. Verify that: "Review duplicates" button appears.

Do we agree 👍 or 👎

[sobitneupane]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@sobitneupane] The PR that introduced the bug has been identified. Link to the PR:

#40153

• [@sobitneupane] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:

#40153 (comment)

• [@sobitneupane] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@sobitneupane] Determine if we should create a regression test for this bug.

Yes.

• [@sobitneupane] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

#49793 (comment)

[mallenexpensify]

Contributor: @daledah paid $250 via Upwork
Contributor+: @sobitneupane owed $250 via NewDot

Test case created

• https://github.com/Expensify/Expensify/issues/442377

Thanks!