[$250] Update second Allow location access modal on web

[jamesdeanexpensify]

On web only, for the second Allow location access modal only (the one with the Got it button):

• Fix the bug where you can't submit after clicking Got it (see video below)
• Fix the bug where, after clicking the Got it button, the same button quickly flickers to say Continue (same video below)
• Update the copy on the modal slightly to:

Allow location access
Location access helps us keep your timezone and currency accurate wherever you go. Please allow location access from your device's permission settings.

• Remove the Not now button entirely because it serves no purpose in this case

2024-10-10_09-11-41.mp4

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021847227311681373401
• Upwork Job ID: 1847227311681373401
• Last Price Increase: 2024-10-25
• Automatic offers:
• alitoshmatov | Reviewer | 104624114
• truph01 | Contributor | 104624115

Issue Owner

Current Issue Owner: @truph01

[melvin-bot]

Triggered auto assignment to @Christinadobrzyn (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[truph01]

Edited by proposal-police: This proposal was edited at 2024-10-17 18:30:45 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

• Remove "Allow location access" modal on web

What is the root cause of that problem?

• When pressing on submit button, we check whether we should start a permission flow:
  

  App/src/pages/iou/request/step/IOURequestStepConfirmation.tsx

  Line 592 in 7bec576

  if (shouldStartLocationPermissionFlow) {

if so, the startPermissionFlow is set to true then this useEffect is called:

App/src/components/LocationPermissionModal/index.tsx

Lines 22 to 36 in 4c90d62

	useEffect(() => {
	if (!startPermissionFlow) {
	return;
	}
	getLocationPermission().then((status) => {
	if (status === RESULTS.GRANTED || status === RESULTS.LIMITED) {
	return onGrant();
	}
	setShowModal(true);
	setHasError(status === RESULTS.BLOCKED);
	});
	// eslint-disable-next-line react-compiler/react-compiler, react-hooks/exhaustive-deps -- We only want to run this effect when startPermissionFlow changes
	}, [startPermissionFlow]);

• First, it checks the current permission. If it is RESULTS.GRANTED or RESULTS.LIMITED, it don't show any modal. Otherwise, the modal is shown.

• This modal is to:

pre-prompt the user for their location access instead of using the native prompt from Apple/Google that would penalize you if you asked for location access too many times. This way, we can prompt users with our own modal on mobile to get a response before the native prompt, avoiding any penalties if the answer is "no" but still allowing us to ask as many times as we want.

• When user chooses "Confirm" button, then the native prompt is shown. In this issue, we are going to remove pre-prompt.

What changes do you think we should make in order to solve the problem?

• As I mentioned above, In this issue, we are going to remove pre-prompt. So the permission flow will be: Checking existing permission > displaying native prompt > sending expense instead of Checking existing permission > display custom pre-prompt > displaying native prompt > sending expense.

• To match the new flow, we can create a new index.website.ts, its logic is the same as index.ts, just need to update the useEffect:

App/src/components/LocationPermissionModal/index.tsx

Lines 22 to 36 in 4c90d62

	useEffect(() => {
	if (!startPermissionFlow) {
	return;
	}
	getLocationPermission().then((status) => {
	if (status === RESULTS.GRANTED || status === RESULTS.LIMITED) {
	return onGrant();
	}
	setShowModal(true);
	setHasError(status === RESULTS.BLOCKED);
	});
	// eslint-disable-next-line react-compiler/react-compiler, react-hooks/exhaustive-deps -- We only want to run this effect when startPermissionFlow changes
	}, [startPermissionFlow]);

useEffect(() => {
    if (!startPermissionFlow) {
        return;
    }

    getLocationPermission().then((status) => {
        if (status === RESULTS.GRANTED || status === RESULTS.LIMITED) {
            return onGrant();
        }
        
        // If the user has previously denied the permission, we still need to show a modal
        // to inform them that they must go to the settings page to enable location permission.
        if (status === RESULTS.BLOCKED) {
            setShowModal(true);
            setHasError(status === RESULTS.BLOCKED);
        } else {
            // If the native permission prompt hasn't been shown before, show it now.
            grantLocationPermission();
        }
    });
    
    // eslint-disable-next-line react-hooks/exhaustive-deps -- We only want this effect to run when startPermissionFlow changes.
}, [startPermissionFlow]);

What alternative solutions did you explore? (Optional)

Solution for new design:

1. Update:

App/src/components/LocationPermissionModal/index.tsx

Line 85 in 4c90d62

<ConfirmModal

        <ConfirmModal
            shouldShowCancelButton={!(isWeb && hasError)}
            onModalHide={() => {
                setHasError(false);
                resetPermissionFlow();
            }}

2. Update:

App/src/components/LocationPermissionModal/index.tsx

Lines 38 to 49 in 4c90d62

	const handledBlockedPermission = (cb: () => void) => () => {
	if (hasError) {
	if (Linking.openSettings) {
	Linking.openSettings();
	}
	setShowModal(false);
	setHasError(false);
	resetPermissionFlow();
	return;
	}
	cb();
	};

    const handledBlockedPermission = (cb: () => void) => () => {
        if (hasError) {
            if (Linking.openSettings) {
                Linking.openSettings();
            } else {
                onDeny?.();
            }
            setShowModal(false);
            return;
        }
        cb();
    };

3. Update the title:

App/src/components/LocationPermissionModal/index.tsx

Line 94 in 4c90d62

title={translate(hasError ? 'receipt.locationErrorTitle' : 'receipt.locationAccessTitle')}

and prompt:

App/src/components/LocationPermissionModal/index.tsx

Line 92 in 4c90d62

prompt={translate(hasError ? 'receipt.locationErrorMessage' : 'receipt.locationAccessMessage')}

to match the new design:

Allow location access
Location access helps us keep your timezone and currency accurate wherever you go. Please allow location access from your device's permission settings.

It is very straightforward:

            prompt={translate(hasError ? (isWeb ? {new_prompt} : 'receipt.locationErrorMessage') : 'receipt.locationAccessMessage')}
            title={translate(hasError ? (isWeb ? {new_title} : 'receipt.locationErrorTitle') : 'receipt.locationAccessTitle')}

[truph01]

@jamesdeanexpensify We don't want to display the pre-prompt but still display the native prompt on web, no?

[jamesdeanexpensify]

Yes, we would still show the native prompt on web. Thanks!

[twilight2294]

Edited by proposal-police: This proposal was edited at 2024-10-15 11:18:52 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Remove "Allow location access" modal on web

What is the root cause of that problem?

Feature request

What changes do you think we should make in order to solve the problem?

New Solution according to expected results:

1. Call skipLocationPermission when we click got it on web:
2. Introduce shouldShowCancelButton prop to ConfirmModal:

And update the locationErrorMessage message to Location access helps us keep your timezone and currency accurate wherever you go. Please allow location access from your device's permission settings., if this doesn't fit screen then minor style changes would also be needed. But

        <ConfirmModal
            onConfirm={(hasError && isWeb) ? skipLocationPermission : grantLocationPermission}
            shouldShowCancelButton={!(hasError && isWeb)}

These changes are enough to match the expected results in this case

[truph01]

@jamesdeanexpensify @Julesssss In my opinion, I don’t think we can fully hide the modal

Previously, when the user clicked the submit button and the native prompt hadn’t been shown yet, we displayed the pre-prompt modal:

If the user chose 'Continue,' but location permission wasn’t granted, the native prompt wouldn’t appear in the future. That's why, the next time, we display a modal to inform them that they need to manually enable location permission:

So, the 2nd modal should not be hidden.

[melvin-bot]

@Julesssss, @Christinadobrzyn Whoops! This issue is 2 days overdue. Let's get this updated quick!

[Christinadobrzyn]

Thanks for the feedback @truph01!

Sorry, just catching up here, can you confirm the difference you are proposing? I think it's that we only show the "Not Now"/"Got it" prompt on the web and not the pre-prompt? Is that right?

[truph01]

I think it's that we only show the "Not Now"/"Got it" prompt on the web and not the pre-prompt

Yes

[Christinadobrzyn]

I think this makes sense - do you @Julesssss @jamesdeanexpensify? Do you think we need a consensus from the team about this?

[Julesssss]

That seems to be what we agreed, but lets check in with James first.

[jamesdeanexpensify]

We're discussing this one internally and may recommend an alternative course of action. Stay tuned!

[jamesdeanexpensify]

Just for alignment purposes - by "native prompt" on web, are we all talking about the second screenshot here?

[twilight2294]

Just for alignment purposes - by "native prompt" on web, are we all talking about the second screenshot here?

Yes

[twilight2294]

The video you attached is not being played, can you add another

[twilight2294]

I actually think on web we can probably leave these prompts entirely in place, but (again, on web only):

@jamesdeanexpensify this means that we only show the prompt on native devices right?

[jamesdeanexpensify]

Hmmm...that video is working for me. Here it is again:

2024-10-10_09-11-41.mp4

And sorry, what do you mean by "only show the prompt on native devices"?

[truph01]

Just for alignment purposes - by "native prompt" on web, are we all talking about the second screenshot #50601 (comment)?

• When users sign-in on a new device and are not asked about the location permission before. If they create a scan expense, the modal below is displayed, it is "pre-prompt":

• If the user chooses "Continue", the modal below is displayed (in top left screen), it is "native prompt":

• If the user chooses "Block", and then creates an other expense, the modal below is displayed:

• If the user chooses "Got it", the modal will close.

[jamesdeanexpensify]

Ah, that's super helpful! Bringing this back to the team to chat about next steps again. Thanks!

[jamesdeanexpensify]

OK, here is where we landed:

On web only, for the second Allow location access modal only (the one with the Got it button):

• Fix the bug where you can't submit after clicking Got it (see video below)
• Fix the bug where, after clicking the Got it button, the same button quickly flickers to say Continue (same video below)
• Update the copy on the modal slightly to:

Allow location access
Location access helps us keep your timezone and currency accurate wherever you go. Please allow location access from your device's permission settings.

• Remove the Not now button entirely because it serves no purpose in this case

2024-10-10_09-11-41.mp4

[twilight2294]

@jamesdeanexpensify so by only web we mean that there should be no change to the behaviour on native platforms right ?

[truph01]

Proposal updated

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @alitoshmatov (External)

[melvin-bot]

@Julesssss, @Christinadobrzyn, @alitoshmatov Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[Christinadobrzyn]

@alitoshmatov can you please check out the proposals when you have a moment? TY!

[melvin-bot]

@Julesssss @Christinadobrzyn @alitoshmatov this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[Julesssss]

Hi @alitoshmatov, are you able to review?

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[melvin-bot]

@Julesssss, @Christinadobrzyn, @alitoshmatov Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[alitoshmatov]

@truph01 Thank you for your proposal, your RCA is correct and your alternative solution is solving the issue.

[alitoshmatov]

@twilight2294 Thank you for your proposal, I don't think your solution is complete and covers all cases here.

[alitoshmatov]

We can go with @truph01 's alternative proposal here

C+ reviewed 🎀 👀 🎀

[melvin-bot]

Current assignee @Julesssss is eligible for the choreEngineerContributorManagement assigner, not assigning anyone new.

[Julesssss]

I agree, thanks everyone for your patience.

[melvin-bot]

📣 @alitoshmatov 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

📣 @truph01 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[truph01]

PR is ready

[truph01]

@jamesdeanexpensify Can you give me a translation for the text "Location access helps us keep your timezone and currency accurate wherever you go. Please allow location access from your device's permission settings."?

[Julesssss]

Hi @truph01 I have requested a translation and will get back to you soon

[jamesdeanexpensify]

Thanks @Julesssss ! Saw they got back with this approved translation @truph01

El acceso a la ubicación nos ayuda a mantener tu zona horaria y moneda precisas dondequiera que estés. Por favor, permite el acceso a la ubicación en la configuración de permisos de tu dispositivo.

[Christinadobrzyn]

monitoring PR - #51709