[HOLD for payment 2024-10-29] [$250] Dupe detect - Tag name on the confirmation page follows custom tag name from other workspace

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.0.48-0
Reproducible in staging?: Y
Reproducible in production?: Y
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team

Action Performed:

Precondition:

• There are two workspaces.
• Each workspace has enabled Tags and has custom tag name.

1. Go to staging.new.expensify.com
2. Go to workspace chat A.
3. Submit an expense.
4. Go to workspace chat B.
5. Submit the same expense as Step 3.
6. Submit another dupe expense on both workspaces (a different amount).
7. Go back to workspace chat A and open the transaction thread from Step 3 (because Keep this one button won't appear in Step 9 if this is not opened first).
8. Go to transaction thread of the expense from Step 5.
9. Click Review duplicates.
10. Click Keep this one on the second expense in the list (this expense is from Step 3).
11. Proceed to confirmation page.

Expected Result:

The tag name on the confirmation page will show the custom tag name from workspace A, because the expense from workspace A is selected on review duplicates page (from Step 9).

Actual Result:

The tag name on the confirmation page shows the custom tag name from workspace B, when the expense from workspace A is selected.

Workaround:

Unknown

Platforms:

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6631903_1728656891431.20241011_221936.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021845671687760709934
• Upwork Job ID: 1845671687760709934
• Last Price Increase: 2024-10-14
• Automatic offers:
• suneox | Reviewer | 104426916
• truph01 | Contributor | 104426918

Issue Owner

Current Issue Owner: @Christinadobrzyn

[melvin-bot]

Triggered auto assignment to @Christinadobrzyn (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[IuliiaHerets]

We think that this bug might be related to #wave-control

[IuliiaHerets]

@Christinadobrzyn FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[truph01]

Edited by proposal-police: This proposal was edited at 2024-10-12 06:06:56 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

The tag name on the confirmation page shows the custom tag name from workspace B, when the expense from workspace A is selected.

What is the root cause of that problem?

• The policyTagList data comes from incorrect logic:

App/src/components/ReportActionItem/MoneyRequestView.tsx

Line 93 in e4969b2

const [policyTagList] = useOnyx(`${ONYXKEYS.COLLECTION.POLICY_TAGS}${policyID}`);

because policyID points to the policyID of the report that we are opening:

App/src/pages/TransactionDuplicate/Confirmation.tsx

Line 45 in e4969b2

const [report, reportResult] = useOnyx(`${ONYXKEYS.COLLECTION.REPORT}${route.params.threadReportID}`);

caused the bug that confirmation page shows the custom tag name from workspace B, when the expense from workspace A is selected.

What changes do you think we should make in order to solve the problem?

• We can change the logic to get the policy tag list from:
  

  App/src/components/ReportActionItem/MoneyRequestView.tsx

  Line 93 in e4969b2

  const [policyTagList] = useOnyx(`${ONYXKEYS.COLLECTION.POLICY_TAGS}${policyID}`);

  
  to:

    const targetPolicyID = updatedTransaction?.reportID ? ReportUtils.getReport(updatedTransaction?.reportID)?.policyID : policyID;
    const [policyTagList] = useOnyx(`${ONYXKEYS.COLLECTION.POLICY_TAGS}${targetPolicyID}`);

and apply it to other similar places.

What alternative solutions did you explore? (Optional)

[Christinadobrzyn]

Oh interesting - I can reproduce this, I think this can be external so let's start there.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021845671687760709934

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @suneox (External)

[suneox]

The proposal from @truph01 LGTM. In this case, since we have an updatedTransaction so we should retrieve the target policy from the updatedTransaction

🎀 👀 🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @MariaHCD, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[MariaHCD]

Sounds good to me 👍🏼

[melvin-bot]

📣 @suneox 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

📣 @truph01 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.51-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix: Incorrect tag name on the confirmation page #50807

If no regressions arise, payment will be issued on 2024-10-29. 🎊

For reference, here are some details about the assignees on this issue:

• @suneox requires payment automatic offer (Reviewer)
• @truph01 requires payment automatic offer (Contributor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@suneox] The PR that introduced the bug has been identified. Link to the PR:
• [@suneox] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@suneox] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@suneox] Determine if we should create a regression test for this bug.
• [@suneox] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@Christinadobrzyn] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[suneox]

Checklist

• [@suneox] The PR that introduced the bug has been identified. Link to the PR: N/A
• [@suneox] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. There isn’t an offending PR in this case, as this issue cover an edge case in the update transaction process and the tag list was implemented a long time ago.
• [@suneox] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
• [@suneox] Determine if we should create a regression test for this bug: N/A
• [@suneox] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again. N/A

[Christinadobrzyn]

Looks like payment is tomorrow. No regression test is needed.

Payouts due:

• Contributor: $250 @truph01 (Upwork offer - https://www.upwork.com/nx/wm/offer/104426918)
• Reviewer: $250 @suneox (Upwork offer - https://www.upwork.com/nx/wm/offer/104426916)

[Christinadobrzyn]

Paid this out - closing.