[HOLD for payment 2024-11-13] [$250] Expensify Card - "Add shipping details" button still appears when the card is deactivated

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.0.48-0
Reproducible in staging?: Y
Reproducible in production?: Y
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team

Action Performed:

Precondition:

• User has assigned a physical card to self.
• Private details have not been added.

1. Go to staging.new.expensify.com
2. Go to workspace settings > Expensify Card.
3. Click on the Expensify Card that is assigned to yourself.
4. Click Deactivate card.
5. Deactivate the card.
6. Go to workspace chat.

Expected Result:

"Add shipping details" button will not appear since the card is deactivated.

Actual Result:

"Add shipping details" button still appears when the card is deactivated.

Workaround:

Unknown

Platforms:

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6633297_1728811970050.20241013_172918.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021846577574853745828
• Upwork Job ID: 1846577574853745828
• Last Price Increase: 2024-10-16
• Automatic offers:
• hoangzinh | Reviewer | 104523414
• truph01 | Contributor | 104523417

Issue Owner

Current Issue Owner: @zanyrenney

[melvin-bot]

Triggered auto assignment to @zanyrenney (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[IuliiaHerets]

We think that this bug might be related to #wave-collect - Release 2

[IuliiaHerets]

@zanyrenney FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[truph01]

Edited by proposal-police: This proposal was edited at 2024-10-16 16:42:03 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

"Add shipping details" button still appears when the card is deactivated.

What is the root cause of that problem?

• We show the "Add shipping card" butotn without checking if the card is deactivated or not:

App/src/components/ReportActionItem/IssueCardMessage.tsx

Line 40 in e4969b2

const shouldShowAddMissingDetailsButton = action?.actionName === CONST.REPORT.ACTIONS.TYPE.CARD_MISSING_ADDRESS && missingDetails && isAssigneeCurrentUser;

What changes do you think we should make in order to solve the problem?

• Should check whether the card is existed/actived or not:

  const cardIssuedActionOriginalMessage = ReportActionsUtils.isActionOfType(
        action,
        CONST.REPORT.ACTIONS.TYPE.CARD_ISSUED,
        CONST.REPORT.ACTIONS.TYPE.CARD_ISSUED_VIRTUAL,
        CONST.REPORT.ACTIONS.TYPE.CARD_MISSING_ADDRESS,
    )
        ? ReportActionsUtils.getOriginalMessage(action)
        : undefined;
    const cardID = cardIssuedActionOriginalMessage?.cardID ?? -1;
    const isPolicyAdmin = PolicyUtils.isPolicyAdmin(PolicyUtils.getPolicy(policyID));
    const card = isPolicyAdmin ? cardsList?.[cardID] : cardList[cardID];
    const shouldShowAddMissingDetailsButton = !isEmptyObject(card) && action?.actionName === CONST.REPORT.ACTIONS.TYPE.CARD_MISSING_ADDRESS && missingDetails && isAssigneeCurrentUser;

What alternative solutions did you explore? (Optional)

[zanyrenney]

Agreed, this button shouldn't be there!

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021846577574853745828

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @hoangzinh (External)

[SWS-5007]

Hi, Here is my suggestion.

1. Check card Status:
   Before rendering the "Add shipping details" button, we should check the status of the card if it is active or deactivated.
   We can add conditional statement that checks the card's activate status.

2. Check Backend:
   We should ensure that Backend properly sends the card's status in the response.

3. Modify Frontend:
   In the Frontend, we can update code handling the display of button like below:

// Assuming `card` is the card object and `card.status` indicates if it's active
const shouldShowAddShippingDetailsButton = (card) => {
    return card.status === 'active' && !card.hasShippingDetails;
};

if (shouldShowAddShippingDetailsButton(card)) {
    // Show the button
} else {
    // Hide the button
}

4. Update Existing Logic:
   Maybe, we can add an additional condition in the existing card rendering functions or React Components.

If we discuss more details about current issue and help me to check your codebase as soon, I can provide with better solution.
Good luck!

[melvin-bot]

📣 @SWS-5007! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Make sure you've read and understood the contributing guidelines.
2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[hoangzinh]

@SWS-5007 Thanks for your proposal. Please follow proposal template here https://github.com/Expensify/App/blob/main/contributingGuides/PROPOSAL_TEMPLATE.md

[hoangzinh]

@truph01's proposal looks good to me.

Link to proposal #50693 (comment)

🎀👀🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @jasperhuangg, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[melvin-bot]

@hoangzinh, @jasperhuangg, @zanyrenney Whoops! This issue is 2 days overdue. Let's get this updated quick!

[melvin-bot]

📣 @hoangzinh 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

📣 @truph01 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.57-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix: hide Add shipping details if deactivated #51230

If no regressions arise, payment will be issued on 2024-11-13. 🎊

For reference, here are some details about the assignees on this issue:

• @hoangzinh requires payment automatic offer (Reviewer)
• @truph01 requires payment automatic offer (Contributor)

[melvin-bot]

@hoangzinh @zanyrenney The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]