[$250] Search - Missing translations for "Search" modal in Spanish

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: v9.0.50-0
Reproducible in staging?: Y
Reproducible in production?: N/A - new feature, doesn't exist in prod
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team

Action Performed:

PreCond: App language is in Spanish

1. Access staging.new.expensify.com
2. Sign into a valid account
3. Tap CMD + K
4. Scroll down on the Search modal

Expected Result:

User expects everything to be translated to Spanish

Actual Result:

The filters and things like "Track your Expense" are showing in English

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6637228_1729136566559.Search_features_are_not_translated_to_Spanish.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021849836084822280137
• Upwork Job ID: 1849836084822280137
• Last Price Increase: 2024-10-25
• Automatic offers:
• shubham1206agra | Reviewer | 104641555

Issue Owner

Current Issue Owner: @shubham1206agra

[melvin-bot]

Triggered auto assignment to @lakchote (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[melvin-bot]

Triggered auto assignment to @greg-schroeder (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[IuliiaHerets]

We think that this bug might be related to #wave-control

[lakchote]

Not a blocker it's missing translations.

[rayane-djouah]

This is not a bug

[rayane-djouah]

We don't translate search queries and results

[lakchote]

cc @luacmartins for your input

[Kicu]

Exactly what @rayane-djouah said: keywords like type, status I don't see how we could translate - they are part of Search grammar.
Perhaps the values like expense, chat maybe we could translate... but it's still tricky because I'm assuming we couldn't send the translated values to backend.

However displaying different display values to user in the query, but sending untranslated values to backend would be technically possible but will require refactoring how we store the query.
So possibly we could look into this in (or after) 2.5.

[luacmartins]

I agree that the queries are not translated. It seems like we translate the Chat results subtitle/last message if they are a system message, so maybe we can apply the same logic here for the chat results only

[greg-schroeder]

Marking Internal

[ChavdaSachin]

The concierge chat not translated here in video was actually an onboarding task,
and we currently do not translate onboarding tasks.
I have made a proposal here to translate onboarding tasks as well, and in that case this issue also would be solved.

[greg-schroeder]

Can you confirm @luacmartins @lakchote ?

[lakchote]

Can you confirm @luacmartins @lakchote ?

The problem doesn't pertain to the translation of onboarding tasks, it's related to Search's chat results as a whole.

We need to translate them, if they are a system message.

Regarding the logic, @luacmartins I've found it:
Example #1
Example #2 (implementation)

[luacmartins]

Agreed, I had left a comment about it here

[luacmartins]

I think this might be external though.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021849836084822280137

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @shubham1206agra (External)

[melvin-bot]

@lakchote, @luacmartins, @greg-schroeder, @shubham1206agra Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[shubham1206agra]

@Kicu Would you like to work on this?

[Kicu]

@shubham1206agra right now I'm focusing on autocomplete features, mainly: #50976 and #50944 + #50943

So at least for the next 2-3 days Im busy. Can take a look after this is done

[lakchote]

This is not urgent @Kicu.

I'm assigning you to work on it when you'll be able to. The autocomplete PRs are more important.

[melvin-bot]

📣 @shubham1206agra 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[Kicu]

thanks @lakchote in case someone else on our end has free time then we will ask them to grab this instead.

[SzymczakJ]

I've investigated it and the Chat results subtitles/last messages that are system messages that are translated in Chat tab are also translated on SearchRouter.
So this comment is technically resolved.

Do we need to do anything else @luacmartins ?

[luacmartins]

Thanks for investigating this. No, I think that was the only pending thing on this issue, so we're good to close. Thank you all!

[melvin-bot]

@lakchote @luacmartins @greg-schroeder Be sure to fill out the Contact List!