[HOLD for payment 2024-10-29] [HOLD for payment 2024-10-25] Search - Search router text color is gray

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.0.50-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?:
If this was caught during regression testing, add the test name, ID and link from TestRail: #50815
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

Precondition: Light theme should be used.

1. Navigate to https://staging.new.expensify.com/
2. Log in with a Gmail account that has some expenses
3. Navigate to Search - Filters
4. Set any filter that'll give results and click on the "View results" button

Expected Result:

Search router text color should be black

Actual Result:

Search router text color is gray.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6637288_1729143309471.bandicam_2024-10-17_07-24-05-493.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @Christinadobrzyn

[melvin-bot]

Triggered auto assignment to @Christinadobrzyn (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[izarutskaya]

We think this issue might be related to the #collect project.

[FitseTLT]

Edited by proposal-police: This proposal was edited at 2024-10-17 13:03:42 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Search - Search router text color is gray

What is the root cause of that problem?

We are setting searchInputStyle here

App/src/components/Search/SearchRouter/SearchRouterInput.tsx

Line 108 in 4a25c36

inputStyle={[styles.searchInputStyle, inputWidth, styles.pl3, styles.pr3]}

which sets the color to textSupporting

App/src/styles/index.ts

Line 3617 in 4a25c36

color: theme.textSupporting,

What changes do you think we should make in order to solve the problem?

If we want to set it to black we can set the color to themeTextColor

                        inputStyle={[styles.searchInputStyle, styles.themeTextColor, inputWidth, styles.pl3, styles.pr3]}

What alternative solutions did you explore? (Optional)

We can also define a new style which excludes only the color style from searchInputStyle then apply to it because then the default textInput color which is black will be applied.

[luacmartins]

I'll work on this fix since it seems like we had a bad conflict resolution that undid the changes from my PR

[melvin-bot]

Triggered auto assignment to @francoisl (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[luacmartins]

PR in review

[luacmartins]

PR being CPed

[luacmartins]

Fixed in staging

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.50-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Fix search router text style #51036

If no regressions arise, payment will be issued on 2024-10-25. 🎊

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@luacmartins] The PR that introduced the bug has been identified. Link to the PR:
• [@luacmartins] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@luacmartins] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@luacmartins] Determine if we should create a regression test for this bug.
• [@luacmartins] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@Christinadobrzyn] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.51-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Fix search router text style #51036

If no regressions arise, payment will be issued on 2024-10-29. 🎊

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@luacmartins] The PR that introduced the bug has been identified. Link to the PR:
• [@luacmartins] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@luacmartins] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@luacmartins] Determine if we should create a regression test for this bug.
• [@luacmartins] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@Christinadobrzyn] Link the GH issue for creating/updating the regression test once above steps have been agreed upon: