Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Payment due Nov 5th] Payment issue for E/App PR#49677 #51075

Closed
melvin-bot bot opened this issue Oct 18, 2024 · 9 comments
Closed

[Payment due Nov 5th] Payment issue for E/App PR#49677 #51075

melvin-bot bot opened this issue Oct 18, 2024 · 9 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Internal Requires API changes or must be handled by Expensify staff Task

Comments

@melvin-bot
Copy link

melvin-bot bot commented Oct 18, 2024

Issue created to compensate the Contributor+ member for their work on #49677
E/E issue linked to the PR - https://www.github.com/Expensify/Expensify/issues/411554.
Contributor+ member who reviewed the PR - @mollfpr.

Wait 7 days after the PR is deployed to production before issuing payment in case there are regressions.

@melvin-bot melvin-bot bot added Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Task Weekly KSv2 labels Oct 18, 2024
@melvin-bot melvin-bot bot added the Internal Requires API changes or must be handled by Expensify staff label Oct 18, 2024
Copy link
Author

melvin-bot bot commented Oct 18, 2024

Triggered auto assignment to @Christinadobrzyn (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Oct 18, 2024
@Christinadobrzyn
Copy link
Contributor

Christinadobrzyn commented Oct 21, 2024

PR is under review - #49677

moving back to weekly while we wait for the PR/7 day window

@Christinadobrzyn Christinadobrzyn added Weekly KSv2 and removed Daily KSv2 labels Oct 21, 2024
@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Oct 24, 2024
@Christinadobrzyn
Copy link
Contributor

PR is under review - #49677

moving this back to weekly

@Christinadobrzyn Christinadobrzyn added Weekly KSv2 and removed Daily KSv2 labels Oct 28, 2024
@Christinadobrzyn Christinadobrzyn changed the title Payment issue for E/App PR#49677 [Payment due Nov 5th] Payment issue for E/App PR#49677 Nov 1, 2024
@Christinadobrzyn
Copy link
Contributor

PR is deployed - payment due Nov 5th

Copy link
Author

melvin-bot bot commented Nov 1, 2024

@mollfpr @Christinadobrzyn this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

@Christinadobrzyn
Copy link
Contributor

Christinadobrzyn commented Nov 5, 2024

Payment is due today.

Payouts due:

  • Reviewer: $250 @mollfpr - Payment through NewDot

@mollfpr can you please accept this Upwork offer

Do we need a regression test for this?

@Christinadobrzyn
Copy link
Contributor

nudge @mollfpr about ^

@mollfpr
Copy link
Contributor

mollfpr commented Nov 6, 2024

Do we need a regression test for this?

@Christinadobrzyn Yes! Also, I'll make a manual request in NewDot.

  1. Open the OldDot
  2. Create a Control workspace with Advanced Approvals
  3. As the admin run this snippet in the console from the workspace admin page: Policy.getCurrent().policy.autoReportingFrequency = 'instant'; Policy.getCurrent().save();
  4. And this one Policy.getCurrent().policy.isPolicyExpenseChatEnabled = true; Policy.getCurrent().save();
  5. Configure the policy as in the screenshot below these test steps.
    image
  6. Submit an expense in NewDot
  7. Login as the approver and approve it (it should now be forwarded to the admin)
  8. Now log back in as the submitter and create another expense
  9. Make sure a new report preview was created and that the expense is now in a new report.

@Christinadobrzyn
Copy link
Contributor

Regression test - https://github.com/Expensify/Expensify/issues/442415

Sounds good @mollfpr - I updated the payment summary to show you'll be paid through ND

#51075 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Internal Requires API changes or must be handled by Expensify staff Task
Projects
Status: Done
Development

No branches or pull requests

2 participants