[HOLD for payment 2024-11-11] Remove redundant reassure tests and improve documentation

[mountiny]

Coming from this proposal in Slack.

Problem:

There are redundant/flaky performance tests in the Reassure suite. These tests are difficult to maintain and provide low value, as their scenarios are already covered elsewhere or offer little regression detection. This creates unnecessary complexity, slows down the test suite, and increases the likelihood of false positives.

Solution:

Remove the redundant tests that verify scenarios already covered in separate tests. Eliminate tests that check interactions with minimal impact on regression detection. Focus on retaining tests that provide high-value regression coverage, and reorganize the test suites for better maintainability by moving essential tests to lower levels where they are easier to manage.

• Move the reassure test documentation to the contributingGuidelines
• Update the guidelines to provide more guidance on how to prevent adding any redundant tests

Issue Owner

Current Issue Owner: @strepanier03

[melvin-bot]

Triggered auto assignment to @strepanier03 (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[OlimpiaZurek]

Hi! I'm Olimpia from Callstack and I'd like to work on this issue.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.56-9 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [NOQA] remove redundant performance tests #51461

If no regressions arise, payment will be issued on 2024-11-11. 🎊

For reference, here are some details about the assignees on this issue:

• @OlimpiaZurek does not require payment (Contractor)

[melvin-bot]

@mountiny @strepanier03 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]