Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edge Case - Wrong DeltaTimes in _createMediaSequences(), specifically [ TYPE-A ] #74

Open
Nfrederiksen opened this issue Feb 24, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@Nfrederiksen
Copy link
Collaborator

In function _createMediaSequences()

The Delta times calculation (this.deltaTimes, this.deltaTimesAudio) is wrong in the case where 2 or more segments were added in the next sequence.

The var positionIncrement assumes that the last segment in the sequence is the only newly added one. So eg. in the case where a sequence popped a 6s segment and added two 3s segments, currently the second segment duration is not accounted for in the delta times.

It has gone unnoticed since the side effects were not apparent in most use cases. But if you have a case where deltaTimes and playhead positions are important, then this should be fixed.

NOTE: This is issue already fixed when enabling the this.sequenceAlwaysContainNewSegments option [ TYPE-B ]

@Nfrederiksen Nfrederiksen added the bug Something isn't working label Feb 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant