Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Perform LFS S3 Delete outside of transaction #335

Open
nateiam opened this issue May 13, 2017 · 0 comments
Open

Perform LFS S3 Delete outside of transaction #335

nateiam opened this issue May 13, 2017 · 0 comments

Comments

@nateiam
Copy link
Contributor

nateiam commented May 13, 2017

As a Herd LFS user I want to minimize the amount of time that LFS operations hold database transactions so I can reduce the possibility that a concurrent user operation will receive an optimistic locking error.

Acceptance Criteria

  • LFS file operation that occurs during clean-up does not hold a database transaction while performing the S3 delete operation
  • Any failure in the S3 delete operation fails does not impact the database transaction that updates BData Status.
    • Note that current logic does not even react to failure of S3 delete operation – the transaction to update BData Status is committed either way. So there is no logical change and no reason to have the transaction around the S3 operation anyway. 
@nateiam nateiam added this to the Release 0.43.0 milestone May 13, 2017
FINRAOSS pushed a commit that referenced this issue May 31, 2018
* commit 'e469d2d5bd3d0d9a3a6890b6c54d3c0f2febac45':
  DM-10653 ( Allow non-backwards compatible Schema changes based on Format indicator)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant