Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependencies should be built, not updated #690

Open
2 tasks done
rbren opened this issue Oct 21, 2024 · 0 comments · May be fixed by #692
Open
2 tasks done

Dependencies should be built, not updated #690

rbren opened this issue Oct 21, 2024 · 0 comments · May be fixed by #692
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed

Comments

@rbren
Copy link
Contributor

rbren commented Oct 21, 2024

What happened?

Reckoner runs helm dependency update after cloning a Git repo. This updates dependencies instead of using the Chart.lock versions

Instead, it should run helm dependency build

https://github.com/FairwindsOps/reckoner/blob/master/pkg/helm/helm.go#L106

What did you expect to happen?

Dependencies follow Chart.lock

How can we reproduce this?

Use the git: option on a repo with dependencies

Version

6.0.0

Search

  • I did search for other open and closed issues before opening this.

Code of Conduct

  • I agree to follow this project's Code of Conduct

Additional context

No response

@rbren rbren added bug Something isn't working triage This bug needs triage labels Oct 21, 2024
@sudermanjr sudermanjr added help wanted Extra attention is needed good first issue Good for newcomers and removed triage This bug needs triage labels Oct 21, 2024
@rbren rbren linked a pull request Oct 21, 2024 that will close this issue
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants