Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Localization support #10

Open
2 tasks
Fevol opened this issue Jun 26, 2022 · 4 comments
Open
2 tasks

Localization support #10

Fevol opened this issue Jun 26, 2022 · 4 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@Fevol
Copy link
Owner

Fevol commented Jun 26, 2022

Add localization support for the plugin's UI elements and translation service languages, the list of languages supported is the same as those supported by Obsidian's (see here)

Submit language

IMPORTANT: Currently, the localization system is not fully set-up yet. If you'd like to contribute, please let me know that you're interested, and I'll try to get it sorted out as soon as possible.

If you'd like to add your language to the localizations, follow these steps:

  1. Fork this repository
  2. Edit the JSON file of your language (look for the .ts file containing your language's ISO code in this directory, you can find the ISO code/language locale to which your language here)
  3. Once completed, submit a pull request

Tasks

  • Replace every English string with corresponding localization identifier
  • Make localization process easier (introducing new localization strings should be quick)
@Fevol Fevol added enhancement New feature or request help wanted Extra attention is needed labels Jun 26, 2022
@andremeireles
Copy link

andremeireles commented Jan 16, 2023

Hello.
Not wanting to rush you, but is there a timeline for this issue?
I am translating it to pt-br and only the list of languages ​​was refreshed as pt-br.
I haven't made the pull request yet because I wanted to make sure everything is correct before submitting it.

@Fevol
Copy link
Owner Author

Fevol commented Jan 16, 2023

Many thanks for reaching out @andremeireles!

Aside from translating languages, the localization system for settings/commands/etc. has not been set-up yet. I will not have the time to implement that for the next two weeks, so timeline for the feature should be a month at most. However, if you've added translations of the languages for pt-br, I can absolutely add those in quickly, since that system already works.

No need to worry about anything going wrong, the worst that could happen is that the words will stay English and not get translated.

(Note that the localization strings for non-languages, i.e. these, might get changed soon, so no need to add translations for those yet)

@Fevol
Copy link
Owner Author

Fevol commented Jan 16, 2023

Hopefully it's not too late, but I just realized that you might be able to reuse the majority of the translations for pt-BR from pt. I don't speak the language, but I assume there is significant overlap between Portuguese and Brazilian Portuguese?

@andremeireles
Copy link

andremeireles commented Jan 18, 2023

You're right, it's not too late, it's possible to reuse the pt list with minor modifications.

I will be waiting for your return and the implementations and as soon as they are available, I will sent you the UI strings because I got really excited about them, so I wanted to prioritize that instead of the list of languages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
Status: Backlog
Development

No branches or pull requests

2 participants