Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

content expiry popup can't save #3

Open
joshyu opened this issue May 17, 2024 · 0 comments
Open

content expiry popup can't save #3

joshyu opened this issue May 17, 2024 · 0 comments

Comments

@joshyu
Copy link
Member

joshyu commented May 17, 2024

When we click "additional content setting" in versions list, the setting dialog should be pop up, but now it's opened in the same window. When we click on the "save" button, the page can't be closed, but turn empty with a title "page closing... "

under:
Django: 4.2.11
Django CMS: 4.0.1.dev4
djangocms-content-expiry: 1.6.0

This is a issue due to Django 4.2 upgrade.
The PR: https://github.com/django/django/pull/15301/files#diff-e01b712e0ef2ea7a3d38e6482034814eef4dea24166eb6484b5d1ce204980d27

image

So we have to add data-popup=yes to the link with class related-widget-wrapper-link.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant