Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Including .ini, .m files, .py in distribution. #135

Open
donnaaboise opened this issue Sep 12, 2018 · 1 comment
Open

Including .ini, .m files, .py in distribution. #135

donnaaboise opened this issue Sep 12, 2018 · 1 comment

Comments

@donnaaboise
Copy link
Member

Add any extra files to the EXTRA_DIST flag, i.e. in the swirl example, we have added :

EXTRA_DIST += \
	applications/clawpack/advection/2d/swirl/fclaw_options.ini \
	applications/clawpack/advection/2d/swirl/regression.ini \
	applications/clawpack/advection/2d/swirl/afterframe.m \
	applications/clawpack/advection/2d/swirl/setplot2.m \
	applications/clawpack/advection/2d/swirl/swirl.ipynb \
	applications/clawpack/advection/2d/swirl/make_plots.py

The problem is that this is only conditionally included, since the Makefile.am is only conditionally included. As a result, it is NOT included in a distribution. To get around this, we need to make sure that EXTRA_DIST is always included (not only conditionally). As a work-around, these can be included AFTER the conditional compile in Makefile.apps

@donnaaboise donnaaboise added this to the Build system milestone Sep 12, 2018
@cburstedde
Copy link
Member

A fix would be to always include all Makefile.ams, and use the conditional checks inside each Makefile.am.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants