-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automatically update examples #165
Comments
A prerequisite for this is to have PROTEUS running via GitHub actions. This should be done through a separate issue, and is also related to implementing some more tests. |
Can't do this on the main branch because of branch protection. |
As in, because we require changes to be made through a PR? |
Yeah, exactly |
Makes sense. Maybe in we could consider having the model run examples and package them as an artefact? Particularly if the examples are only to be run when a release is generated. Would this have permissions issues? |
I'm not entirely sure how that would work, artifacts are not great to work with (they are more of a developer thing) and you cannot link them directly, which is a major bottleneck. |
It is useful to store example results for several reasons:
There are currently two examples, which I ran manually from the 'default' and 'dummy' configs, and then copied to the examples folder with 'tools/MakeExample.sh`. However, they are now out of date.
It would be better if these examples were automatically updated. This could potentially operate via a GitHub action, triggered when a release is created.
The text was updated successfully, but these errors were encountered: