Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Plotting tests fail because of different image sizes #192

Open
lsoucasse opened this issue Sep 26, 2024 · 2 comments
Open

Plotting tests fail because of different image sizes #192

lsoucasse opened this issue Sep 26, 2024 · 2 comments
Labels
bug Something isn't working help wanted Extra attention is needed JOSS publication: PROTEUS TBD before PROTEUS JOSS publication Priority 3: standard Priority level 3: medium time criticality or importance software Relating to software and implementation

Comments

@lsoucasse
Copy link
Member

When comparing reference plots with CI plots, the image sizes are slightly different.

I tried to resize the image before using the compare_image function of matplotlib in tests/integration/test_dummy_integration.py, but the resizing creates small shifts in axes and labels which make the comparison not relevant.
@lsoucasse lsoucasse added bug Something isn't working help wanted Extra attention is needed labels Sep 26, 2024
@lsoucasse lsoucasse changed the title Plotting tests fail becaus of different image sizes Plotting tests fail because of different image sizes Sep 26, 2024
@lsoucasse lsoucasse added the software Relating to software and implementation label Nov 11, 2024
@timlichtenberg
Copy link
Collaborator

It seems these reference plots are quite sensitive to minor changes in various things. Do we think it is a long-lasting solution to directly compare reference plots to one another or should we systematically resort to comparing only output numbers?

@timlichtenberg timlichtenberg added the Priority 3: standard Priority level 3: medium time criticality or importance label Nov 19, 2024
@lsoucasse
Copy link
Member Author

It seems these reference plots are quite sensitive to minor changes in various things. Do we think it is a long-lasting solution to directly compare reference plots to one another or should we systematically resort to comparing only output numbers?

I quite like the idea to test the plots but I don't think it should be systematic for all tests as it involves managing many files.

@timlichtenberg timlichtenberg added the JOSS publication: PROTEUS TBD before PROTEUS JOSS publication label Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working help wanted Extra attention is needed JOSS publication: PROTEUS TBD before PROTEUS JOSS publication Priority 3: standard Priority level 3: medium time criticality or importance software Relating to software and implementation
Projects
PROTEUS Development Roadmap
Status: JOSS Publication
Milestone
No milestone
Development

No branches or pull requests
2 participants
@timlichtenberg @lsoucasse