Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix new search field #84

Closed
wants to merge 6 commits into from

Conversation

rafaucau
Copy link
Contributor

@rafaucau rafaucau commented Jan 13, 2022

**Fixes #83 **

Changes proposed in this pull request:

This PR fixes the styles of the new search box.
Additionally, it updates the imports in JS files.

Reviewers should focus on:

Screenshot

Before:

image
image
image

2022-01-13.08-56-31.mp4

After:

image
image
image

2022-01-14.20-45-08.mp4

Confirmed

  • Frontend changes: tested on a local Flarum installation.

@rafaucau

This comment has been minimized.

@rafaucau

This comment has been minimized.

@rafaucau rafaucau changed the title [WIP] Fix new search field Fix new search field Jan 14, 2022
@rafaucau rafaucau marked this pull request as ready for review January 14, 2022 19:48
@rafaucau
Copy link
Contributor Author

@imorland Why were other PRs accepted while this one fixes more things? This PR came first.
Those PRs, for example, did not fix the problem with text going off-screen.

@rafaucau rafaucau closed this Feb 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Problem with styles after updating to 1.2
1 participant