Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DID:PKH:TZ is wrong #26

Open
jdsika opened this issue Apr 2, 2024 · 4 comments
Open

DID:PKH:TZ is wrong #26

jdsika opened this issue Apr 2, 2024 · 4 comments
Assignees
Labels
bug Something isn't working

Comments

@jdsika
Copy link

jdsika commented Apr 2, 2024

currently:
"id": "did:pkh:tz:tz1WvvbEGpBXGeTVbLiR6DYBe1izmgiYuZbq",

According to spec here

"id": "did:pkh:tezos:mainnet:tz1WvvbEGpBXGeTVbLiR6DYBe1izmgiYuZbq",
"id": "did:pkh:tezos:NetXdQprcVkpaWU:tz1WvvbEGpBXGeTVbLiR6DYBe1izmgiYuZbq",

Update: added "pkh" which I left out by mistake if you compare it with the link to the example

@jfelixh jfelixh added the question Further information is requested label Apr 8, 2024
@jfelixh jfelixh self-assigned this Apr 8, 2024
@jfelixh
Copy link
Collaborator

jfelixh commented Apr 8, 2024

Where is the current example from? To my knowledge, we are not using did:tezos at all. At least for now, the idea was to fully rely on did:pkh:tz, to avoid the need for a connection to a ledger node. That simplifies development and test deployments.

@jdsika
Copy link
Author

jdsika commented Apr 8, 2024

It was just a typo on my side which I corrected now if you open the table with examples

@jdsika
Copy link
Author

jdsika commented Apr 8, 2024

The library from spruce is apparently not aligned with the specification draft of did:pkh I linked above.

@jfelixh jfelixh added bug Something isn't working and removed question Further information is requested labels Apr 8, 2024
@jfelixh
Copy link
Collaborator

jfelixh commented Apr 8, 2024

Thanks for clarifying! I was so confused I did not even look at the link. You found a mistake indeed, but I cannot pin it on spruce, because we only use it for the signature itself. We manually construct the DID in our code, so this is a bug that we need to fix in the next version.

@jdsika jdsika changed the title DID:TZ is wrong DID:PKH:TZ is wrong Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants