Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Credential from DB #32

Open
jdsika opened this issue Dec 10, 2024 · 0 comments
Open

Bug: Credential from DB #32

jdsika opened this issue Dec 10, 2024 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@jdsika
Copy link

jdsika commented Dec 10, 2024

Get wrong credential from DB

Test:
Add 4 accounts
1 member account
1 user account
1 other user
1 unknown account

Use user account to login and download the credential:

  • Try to present the unknown account -> error message
  • Try to present the other user -> success. If this is used to sign in then you will be other user.
  • Use the member account to sign -> success. If this is used to sign in then you will login as member

I think the error is here:

image

We miss the check if the presented address is the same address that has been used to sign-in.

@jdsika jdsika added the bug Something isn't working label Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants