Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework search page: show all service offerings #88

Open
lenasauermann opened this issue Aug 12, 2024 · 6 comments
Open

Rework search page: show all service offerings #88

lenasauermann opened this issue Aug 12, 2024 · 6 comments
Assignees

Comments

@lenasauermann
Copy link
Contributor

lenasauermann commented Aug 12, 2024

Same as for #84 but for SoftwareResource as base label

@lenasauermann
Copy link
Contributor Author

As we didn't show this page at all at the Hannover Fair, I'm not sure in what state this page is.

it should look like the Resource page

@lenasauermann
Copy link
Contributor Author

lenasauermann commented Aug 12, 2024

Currently we don't have any SoftwareResource in the FC, so before start, write @lenasauermann and she will upload a few SoftwareResources in the FC

@zoltan: Do you mean Service Offerings instead of SoftwareResource? Because currently the db query which gets the service offerings looks the following way: MATCH (n:ServiceOffering) RETURN properties(n), labels(n) LIMIT 100

@devbysp devbysp self-assigned this Aug 14, 2024
devbysp pushed a commit that referenced this issue Aug 19, 2024
- Re enable ServiceOffering component
- Simplify loading of the data in useEffect
- Use semantically correct components
- Introduce new generic components to structure better the component (Main, LoadingIndicator, CardContainer)
- Refactor css styling in order to match the new data structure
- Reorganize translations
devbysp pushed a commit that referenced this issue Aug 19, 2024
- Re enable ServiceOffering component
- Simplify loading of the data in useEffect
- Use semantically correct components
- Introduce new generic components to structure better the component (Main, LoadingIndicator, CardContainer)
- Refactor css styling in order to match the new data structure
- Reorganize translations

Signed-off-by: Zoltan M. <[email protected]>
@devbysp
Copy link
Contributor

devbysp commented Aug 19, 2024

Implementation

  • Re enable ServiceOfferings component
  • Add filterbar
  • Simplify loading of the data in useEffect
  • Use semantically correct components
  • Introduce new generic components to structure better the component (Main, LoadingIndicator, CardContainer)
  • Refactor css styling in order to match the new data structure
  • Reorganize translations

Pull Requests 1-2

Notes:

devbysp pushed a commit that referenced this issue Aug 20, 2024
- Re enable ServiceOffering component
- Simplify loading of the data in useEffect
- Use semantically correct components
- Introduce new generic components to structure better the component (Main, LoadingIndicator, CardContainer)
- Refactor css styling in order to match the new data structure
- Reorganize translations

Signed-off-by: Zoltan M. <[email protected]>
devbysp pushed a commit that referenced this issue Aug 20, 2024
- Re enable ServiceOffering component
- Simplify loading of the data in useEffect
- Use semantically correct components
- Introduce new generic components to structure better the component (Main, LoadingIndicator, CardContainer)
- Refactor css styling in order to match the new data structure
- Reorganize translations

Signed-off-by: Zoltan M. <[email protected]>
Signed-off-by: Zoltan Magyari <[email protected]>
devbysp pushed a commit that referenced this issue Aug 22, 2024
- Re enable ServiceOffering component
- Simplify loading of the data in useEffect
- Use semantically correct components
- Introduce new generic components to structure better the component (Main, LoadingIndicator, CardContainer)
- Refactor css styling in order to match the new data structure
- Reorganize translations

Signed-off-by: Zoltan M. <[email protected]>
Signed-off-by: Zoltan Magyari <[email protected]>
devbysp pushed a commit that referenced this issue Aug 26, 2024
- Re enable ServiceOffering component
- Simplify loading of the data in useEffect
- Use semantically correct components
- Introduce new generic components to structure better the component (Main, LoadingIndicator, CardContainer)
- Refactor css styling in order to match the new data structure
- Reorganize translations

Signed-off-by: Zoltan M. <[email protected]>
Signed-off-by: Zoltan Magyari <[email protected]>
devbysp pushed a commit that referenced this issue Aug 28, 2024
- Re enable ServiceOffering component
- Simplify loading of the data in useEffect
- Use semantically correct components
- Introduce new generic components to structure better the component (Main, LoadingIndicator, CardContainer)
- Refactor css styling in order to match the new data structure
- Reorganize translations

Signed-off-by: Zoltan Magyari <[email protected]>
devbysp pushed a commit that referenced this issue Aug 28, 2024
- Re enable ServiceOffering component
- Simplify loading of the data in useEffect
- Use semantically correct components
- Introduce new generic components to structure better the component (Main, LoadingIndicator, CardContainer)
- Refactor css styling in order to match the new data structure
- Reorganize translations

Signed-off-by: Zoltan Magyari <[email protected]>
@lenasauermann
Copy link
Contributor Author

lenasauermann commented Oct 2, 2024

Acceptance criteria:

  • list shows all resources of type "SoftwareResource" --> currently its ServiceOffering, that's old and not right anymore
  • title and description are filled out if available
  • link to detail page of a software resource is available
  • on the detail page all properties exept claimsgraphuri are shown in the details card under "Details:"
  • on the detail page the items in claimsgraphuri are shown as "Related Offerings:" under the detail information
  • on the detail page there is a card with the title "Suitable data offerings", where the map is for ressources. Exept the title, the card is empty
  • on the detail page the provider information as well as the contact button can stay hard coded as they are for now

@devbysp
Copy link
Contributor

devbysp commented Oct 6, 2024

Acceptance criteria

  • list shows all resources of type "SoftwareResource" --> currently its ServiceOffering, that's old and not right anymore
  • title and description are filled out if available
  • link to detail page of a software resource is available
  • on the detail page all properties exept claimsgraphuri are shown in the details card under "Details:"
  • on the detail page the items in claimsgraphuri are shown as "Related Offerings:" under the detail information
  • on the detail page there is a card with the title "Suitable data offerings", where the map is for ressources. Exept the title, the card is empty
  • on the detail page the provider information as well as the contact button can stay hard coded as they are for now

Other things solved

  • Fetching data with more efficient cypher query
      MATCH (service)
      WHERE 'SoftwareResource' IN labels(service)

      RETURN
        properties(service).name AS name,
        properties(service).description AS description,
        properties(service).uri AS uri,
        labels(service) AS labels
  • Created a tool for more efficient cypher query development: cypher-query-tool.zip

  • Introducing useReducers for state management. (reduces rerendering, prepares for eventual state management with redux, managing loading and error states)

  • Refactoring for separation of concerns. (loading of data, filtering)

  • Refactored the Routers component to wrap some utility components around the pages in a more simple way

Notes

On Hold

2024.10.07

The task is on hold because currently there are no SoftwareResources in the graph database. I know from @robertschubert that the creation of SoftwareResource is in progress. Its matter of days and it will be ready. Until then nothing really can be done in the story becasue evrything what is left is dependent on the data that we want to display.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants