Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New extension: Supabase #1377

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

github-actions[bot]
Copy link
Contributor

Description

This extension is an upgrade of Supabase save state extension #1067 by @romw314.

Supabase vs Supabase save state

  • Both, Supabase and Supabase save state, use the same JavaScript client by @romw314.
  • Supabase doesn't need a static scheme (setup), however, extension users still need to configure their own Supabase projects.
  • Supabase supports OTP authentication.
  • Supabase supports CRUD and filtering.
  • Supabase retrieves session automatically by saving/loading refresh token.

Comparison

Screenshot_٢٠٢٤-٠٩-١٤-١٦-٣٠-٥٣-٥٨_40deb401b9ffe8e1df2f1cc5ba480b12
Screenshot_٢٠٢٤-٠٩-١٤-١٦-٣٠-٣٨-٠٥_40deb401b9ffe8e1df2f1cc5ba480b12

How to use the extension

  • Get project's URL and key from Supabase.
  • Open the extension in the editor and set SupabaseURL and SupabaseKey.
  • On Supabase.com, currently you have to let anonymouses read tables, no need to let anonymouses create/update/delete.

Checklist

  • I've followed all of the best practices.
  • I confirm that this extension can be integrated to this GitHub repository, distributed and MIT licensed.
  • I am aware that the extension may be updated by anyone, and do not need my explicit consent to do so.

What tier of review do you aim for your extension?

Community (Unreviewed)

Example file

Supabase example.zip

Extension file

Supabase.zip

@github-actions github-actions bot requested a review from a team as a code owner September 14, 2024 13:38
@github-actions github-actions bot added the ✨ New extension A new extension label Sep 14, 2024
@EyadMahm0ud
Copy link

EyadMahm0ud commented Sep 14, 2024

Oh no.
Do I really have to add exception?

@romw314
Copy link

romw314 commented Sep 15, 2024

Yes, that's ok. And, if you want them to check the client, use the unminified version of the client that I built: https://gist.github.com/romw314/42184c41bc21fca206856a446c9e77b1

@EyadMahm0ud
Copy link

Thanks, @romw314. I will use it.
Moreover, I noticed that the extension is spaghetti, so I will rewrite some of the actions.

@EyadMahm0ud
Copy link

!update
Supabase.zip


What's New? (0.9.0 » 1.0.0)

  • Use a non-minified version of the code for easy review, thanks @romw314.
  • Support for new variables system.*
  • Support callback variable with "state", like Firebase.*
  • Support filters and modifiers.
  • Storage support. Delayed

Please note that most functions have become two (JavaScript & Standard Events) to support both.

@EyadMahm0ud
Copy link

I don't really know how to add exceptions for the extension.

@EyadMahm0ud
Copy link

!update
Supabase.zip

  • Better and more consistent event sentences/descriptions.

@EyadMahm0ud
Copy link

!update
Supabase example.zip

Copy link
Contributor Author

❗ An internal error has occurred. See logs at https://github.com/GDevelopApp/GDevelop-extensions/actions/runs/11077373026.

@romw314
Copy link

romw314 commented Sep 28, 2024

!update Supabase example.zip

You shouldn't post the example using !update. Just post it because that's only for the GD extensions team, not for the automation.

Copy link
Contributor Author

❗ An internal error has occurred. See logs at https://github.com/GDevelopApp/GDevelop-extensions/actions/runs/11083023031.

@romw314
Copy link

romw314 commented Sep 30, 2024

❗ An internal error has occurred. See logs at https://github.com/GDevelopApp/GDevelop-extensions/actions/runs/11083023031.

Oh no, my quote of the !update has started the automation pipeline.

Copy link
Contributor Author

❗ An internal error has occurred. See logs at https://github.com/GDevelopApp/GDevelop-extensions/actions/runs/11106717584.

@romw314
Copy link

romw314 commented Oct 3, 2024

❗ An internal error has occurred. See logs at https://github.com/GDevelopApp/GDevelop-extensions/actions/runs/11106717584.

Again? 😆

@romw314
Copy link

romw314 commented Oct 3, 2024

I don't really know how to add exceptions for the extension.

Hi, @EyadMahm0ud, to add the exception, follow these steps:

Fork this repo but disable copy only master branch, create a new branch from the extension/EyadMahm0ud/1376 branch, add the exception into scripts/lib/ExtensionsValidatorExceptions.js in the new branch, and create a new PR from the new branch in your fork to the extension/EyadMahm0ud/1376 branch in this repo. After the GDevelop staff merges the PR you created to add the exception, CircleCI should pass.

For your next extensions, I recommend you creating the PR to submit the extension manually.

@D8H D8H requested a review from a team as a code owner November 7, 2024 09:48
@GDevelopApp GDevelopApp deleted a comment from github-actions bot Nov 7, 2024
@GDevelopApp GDevelopApp deleted a comment from github-actions bot Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ New extension A new extension
Projects
Status: Needs review
Development

Successfully merging this pull request may close these issues.

2 participants