Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Color Picker #1389

Open
3 tasks done
VigorWorks opened this issue Sep 28, 2024 · 9 comments
Open
3 tasks done

Color Picker #1389

VigorWorks opened this issue Sep 28, 2024 · 9 comments
Labels
✨ New extension A new extension

Comments

@VigorWorks
Copy link

VigorWorks commented Sep 28, 2024

Description

This is a color picker to change the color of an object based on the user's selection

bandicam.2024-09-27.22-47-45-706.mp4

How to use the extension

to get RGB : ColorPicker::RGB()

Screenshot 2024-10-04 111802

Checklist

  • I've followed all of the best practices.
  • I confirm that this extension can be integrated to this GitHub repository, distributed and MIT licensed.
  • I am aware that the extension may be updated by anyone, and do not need my explicit consent to do so.

What tier of review do you aim for your extension?

Community (Unreviewed)

Example file

ExampleFile.zip

Extension file

ColorPicker.zip

@VigorWorks VigorWorks added the ✨ New extension A new extension label Sep 28, 2024
Copy link
Contributor

👋 Thanks for your submission! We are sorry, but the filename of the extension has unrecognized characters. Since filenames with weird character can cause all kinds of problems and security flaws, our system won't allow file names with other characters than normal latin upper- and lowercase characters or numbers. Additionally, the first character must be an uppercase character. Please update your original submission post with a new zip file containing your extension with another file name following those guidelines 🙏

@VigorWorks
Copy link
Author

!update
ColorPickerExample.zip

Copy link
Contributor

👋 Thanks for your submission! We are sorry, but the filename of the extension has unrecognized characters. Since filenames with weird character can cause all kinds of problems and security flaws, our system won't allow file names with other characters than normal latin upper- and lowercase characters or numbers. Additionally, the first character must be an uppercase character. Please update your original submission post with a new zip file containing your extension with another file name following those guidelines 🙏

@EyadMahm0ud
Copy link

Hello @VigorWorks, I am not a maintainer but here are some notes:

  • The extension must not be inside a folder inside a zip file, but must be in the zip's root.
  • As per best practices, functions should start with uppercase letters and without abbreviations, e.g. ColorPicker::Red() instead of ColorPicker::r().
  • Why should the color picker be created at the beginning of the scene?
  • Expressions must have description/name according to best practices.
  • Event descriptions must end with period.
  • The parameter names are a bit inconsistent, I recommend you to take inspiration from the core events, for example (X position) and (Hex code).

I believe your extension is promising. 😀

Copy link
Contributor

github-actions bot commented Oct 4, 2024

👋 Thanks for your submission! Unfortunately, all submitted extensions have to meet some minimal quality standard - the extension best practices - and our system has found that your extension does not fully comply 😔. You can find all of those rules on the GDevelop wiki.

The following issues have been found by the system concerning the respect of those best practices by your extension:

  ⟶ ❌ [Dots in sentences]: Field 'shortDescription' of the extension description misses a dot at the end of the sentence!
  ⟶ ❌ [Dots in sentences]: Field 'description' of the function 'CreatePicker' misses a dot at the end of the sentence!
  ⟶ ❌ [Dots in sentences]: Field 'description' of the function 'CheckValue' misses a dot at the end of the sentence!
  ⟶ ❌ [Dots in sentences]: Field 'description' of the function 'SetValue' misses a dot at the end of the sentence!
  ⟶ ❌ [Dots in sentences]: Field 'description' of the function 'RGB' misses a dot at the end of the sentence!
  ⟶ ❌ [Dots in sentences]: Field 'description' of the function 'RED' misses a dot at the end of the sentence!
  ⟶ ❌ [Dots in sentences]: Field 'description' of the function 'GREEN' misses a dot at the end of the sentence!
  ⟶ ❌ [Dots in sentences]: Field 'description' of the function 'BLUE' misses a dot at the end of the sentence!

Please update your original submission post with a new zip file containing your extensions updated to follow those guidelines 🙏

@VigorWorks
Copy link
Author

Hey,thanks for the info.

  • done
  • done
  • When I was developing the extension, I did that for myself and forgot to remove it. Thanks for pointing it out, lol!
  • done
  • done
  • done

I updated this page and also added a new expression

@VigorWorks
Copy link
Author

Updated the extention file again

Copy link
Contributor

github-actions bot commented Oct 4, 2024

👋 Thanks for your submission! Unfortunately, all submitted extensions have to meet some minimal quality standard - the extension best practices - and our system has found that your extension does not fully comply 😔. You can find all of those rules on the GDevelop wiki.

The following issues have been found by the system concerning the respect of those best practices by your extension:

  ⟶ ❌ [Dots in sentences]: Field 'description' of the function 'CreatePicker' misses a dot at the end of the sentence!
  ⟶ ❌ [Dots in sentences]: Field 'description' of the function 'CheckValue' misses a dot at the end of the sentence!
  ⟶ ❌ [Dots in sentences]: Field 'description' of the function 'SetValue' misses a dot at the end of the sentence!
  ⟶ ❌ [Dots in sentences]: Field 'description' of the function 'RGB' misses a dot at the end of the sentence!
  ⟶ ❌ [Dots in sentences]: Field 'description' of the function 'RED' misses a dot at the end of the sentence!
  ⟶ ❌ [Dots in sentences]: Field 'description' of the function 'GREEN' misses a dot at the end of the sentence!
  ⟶ ❌ [Dots in sentences]: Field 'description' of the function 'BLUE' misses a dot at the end of the sentence!

Please update your original submission post with a new zip file containing your extensions updated to follow those guidelines 🙏

@VigorWorks
Copy link
Author

updated it again,I dont think it will show any problem now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ New extension A new extension
Projects
None yet
Development

No branches or pull requests

2 participants