-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New extension SelectionTools. #974
Conversation
It seems I am not allowed to access |
Hi @ayushbhardwas - this looks nice! :)
I think it would be nice to try to fix both of these. I understand it's a fair amount of rework to convert this to a behavior, but please give a try and give a try to avoiding getObjects too :) If you struggle too much, we'll add exceptions so we can merge your extension... but I think it would be future proof to fix both of these 👍 Thank you again for this nice work! 👍 |
Thanks a lot, @4ian |
Changes made:
How to use:
Example |
I haven't looked at the extension, but in your example game, units are not highlighted until the release happens. |
@tristanbob
Edit: My bad, the current condition is already doing the check each cycle so there's no reason why we can not do that 😅. And we can simply have a preselect bool parameter that can be turned on or off even if we don't use an object variable, it will be the same as the normal select condition but won't wait for the shape to be completed as you suggested. Thanks, Tristan ❤️ I think I can do that. I remember our conversation about merging this extension with RTS Unit Selection, which when I looked into it is a very different sort of tool. I think it adds a lot that may be useful for a certain type of game I just don't see myself using it that often. This is supposed to be a more barebone extension. But I haven't forgotten about it, I think RTS Unit Selection would benefit immensely by having a lasso select, which if you allow I would definitely want to implement. On a similar note, you'd agree that you never really use polygonal selection to select units in an RTS so I don't think it needs that, not that it can not be implemented, just that it's not commonly seen in RTS games. |
Changes made:
Example |
Changes made:
[Edited] Notes:
Example |
I intend to make no further changes to the extension before the merger unless someone reports an issue on this PR. Consequently, I eagerly await the extension team's review and approval. |
@ayushbhardwas Many thanks again for the work on this and sorry for the delay here. I think it's fine to go ahead and quite flexible already! If you have a way to ensure this work on touch screen that would be perfect. In the meantime, because it's already well made and you've spent time on this, I'm merging this. Many thanks and keep up the great work 👍 |
Thanks, Florian 😊 |
The extension provides functionality to draw different types of selections in order to select object instances present on the scene.
How to use:
Setup selection tools
action to an event.Set rectangular selection
,Set polygonal selection
, andSet lasso selection
.Example